|
Description
Victoria Faafia
2021-01-21 22:57:35 UTC
Created attachment 115642 [details] [review] adding itemtype image Bug 27522: Adding new itemtype info image to carredart Test Plan 1. Go to Administration>Item Types>Modify Item Type 2. Under carredart you should see an info item type As the itemtype images can be displayed in the OPAC and in the staff interface we currently need to add them in 2 places as one cannot access the image files of the other. Can you also add the files to koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/carredart please? Created attachment 115706 [details] [review] Bug 27522: (follow-up) Add copy of image to carredart icons in the OPAC https://bugs.koha-community.org/show_bug.cgi?id=27505 Created attachment 115707 [details] [review] Bug 27522: (follow-up) Add copy of image to carredart icons in the OPAC Created attachment 115749 [details] [review] Bug 27522: Adding new itemtype info image to carredart Test Plan 1. Go to Administration>Item Types>Modify Item Type 2. Under carredart you should see an info item type Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Created attachment 115750 [details] [review] Bug 27522: (follow-up) Add copy of image to carredart icons in the OPAC Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Works as described. Test Plan 1. Go to Administration>item types>modify item type 2. There should be an info item type under the carredart 3. Modify the item type so one of the new icons is used 4. Search for an item using the above item type 5. Check that the icon displays properly in both the staff client and OPAC Created attachment 115843 [details] [review] Bug 27522: Adding new itemtype info image to carredart Test Plan 1. Go to Administration>Item Types>Modify Item Type 2. Under carredart you should see an info item type Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 115844 [details] [review] Bug 27522: (follow-up) Add copy of image to carredart icons in the OPAC Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Victoria, Aleisha or someone else - as these don't appear to belong to the original carredart item set (I believe this came from a library in Nimes - bug 5640)- where were these new icons taken from? Do we need to add any license information? I think it would be good to document the source here or in the commit message. As they don't perfectly fit the style, maybe we should put them on a separate tab? Sorry if I missed something! Created attachment 122933 [details] [review] Bug 27522: (follow-up) Adding new itemtype info image to carredart This patch adds a new version of the info icon which was created from scratch based on the previous version's design. Created attachment 123164 [details] [review] Bug 27522: Adding new itemtype info image to carredart Test Plan 1. Go to Administration>Item Types>Modify Item Type 2. Under carredart you should see an info item type Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 123165 [details] [review] Bug 27522: (follow-up) Add copy of image to carredart icons in the OPAC Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 123166 [details] [review] Bug 27522: (follow-up) Adding new itemtype info image to carredart This patch adds a new version of the info icon which was created from scratch based on the previous version's design. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> (In reply to Katrin Fischer from comment #11) > Victoria, Aleisha or someone else - as these don't appear to belong to the > original carredart item set (I believe this came from a library in Nimes - > bug 5640)- where were these new icons taken from? > Do we need to add any license information? I think it would be good to > document the source here or in the commit message. > As they don't perfectly fit the style, maybe we should put them on a > separate tab? > > Sorry if I missed something! Has this been answered? It's not clear to me from where are these icons coming and what is the license. Please clarify. I understood it that Owen did a new version of the image from scratch in his 3rd patch, but didn't want the work before to be lost. They are binary files, and if we don't know their origin I don't see how it could be useful to keep them. It was not my intention that both versions of the image be kept in the git history. I should have obsoleted the older patches. Can we squash and clarify in the commit message what's happening here? It seems that the icons were part of Koha (bug 5640) but have been removed (inadvertently) and so we are adding them back? But with a modified version because we didn't know what was the license? Aleisha, do you remember the origin of this bug report? Created attachment 123457 [details] [review] Bug 27522: Adding new itemtype info image to carredart This patch adds an "info" icon to the carredart icon set. It was created from scratch for Koha based on an earlier patch by Victoria Faafia. Test Plan: 1. Go to Administration > Item Types > Modify Item Type 2. Under carredart you should see an "info" item type icon. Assign it to an item type. 3. Go to Administration -> System preferences and make sure that OpacAdvSearchOptions and AdvancedSearchTypes have item type searches enabled. 4. In the OPAC and staff interface, view the advanced search page and confirm that the new icon appears. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> These icons were designed by a Catalyst Academy student (Victoria, who opened the bug report), and she designed them as part of her contribution to the Academy. They are free to use for Koha's image sets. So now we have 2 versions, the one from Victoria and the one from Owen. Do we need both? Why is it named "carredart"? Initially it's coming from bug 5640 for "Carré d'Art" (museum) I've removed my patch and returned the old ones. (In reply to Jonathan Druart from comment #23) > Why is it named "carredart"? Initially it's coming from bug 5640 for "Carré > d'Art" (museum) This is waiting for an answer. Aleisha, maybe? (In reply to Jonathan Druart from comment #25) > (In reply to Jonathan Druart from comment #23) > > Why is it named "carredart"? Initially it's coming from bug 5640 for "Carré > > d'Art" (museum) > > This is waiting for an answer. Aleisha, maybe? That's the name on the item types icon tab. I am really sorry, I got confused and was confusing! I thought we were adding a new set of icons. I have no idea how I understood that, everything is clear when reading the commit message and bug title: we are only adding a new 'info' icon to the existing "carredart" set. Sorry everybody! Pushed to master for 21.11, thanks to everybody involved! |