| Summary: | It should be possible to cancel an ILL request sent to a partner | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Andrew Isherwood <bugzilla> |
| Component: | ILL | Assignee: | Pedro Amorim <pedro.amorim> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | dcook, fridolin.somers, janet.mcgowan, magnus, Niamh.WalkerHeadon, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00
|
|
| Circulation function: | |||
| Attachments: |
Bug 27542: Allow cancellation of partner ILL
Bug 27542: Allow cancellation of partner ILL Bug 27542: (follow-up) Capitalization Bug 27542: (follow-up) Fix unit test Bug 27542: Allow cancellation of partner ILL Bug 27542: (follow-up) Capitalization Bug 27542: (follow-up) Fix unit test Bug 27542: Allow cancellation of partner ILL Bug 27542: (follow-up) Capitalization Bug 27542: (follow-up) Fix unit test |
||
|
Description
Andrew Isherwood
2021-01-25 11:18:02 UTC
Created attachment 115741 [details] [review] Bug 27542: Allow cancellation of partner ILL This commit enables the display of the "Revert request" button when a request's status is GENREQ / "Requested from partners" The relevant unit test has also been updated TEST PLAN - Create a ILL request - Place the request with partners - Modify the request => TEST: Observe that the "Revert request" button is displayed The button text "Revert Request" has incorrect capitalization. When I run the test I get these failures: # Failed test 'Status Graph tests' # Failed test 'Checking out' I don't know if that's relevant. Created attachment 147897 [details] [review] Bug 27542: Allow cancellation of partner ILL This commit enables the display of the "Revert request" button when a request's status is GENREQ / "Requested from partners" The relevant unit test has also been updated Rescued-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 147898 [details] [review] Bug 27542: (follow-up) Capitalization Created attachment 147899 [details] [review] Bug 27542: (follow-up) Fix unit test We've been backporting this into production for 2 years now.. be nice to see it get into 23.05 ;) Created attachment 150641 [details] [review] Bug 27542: Allow cancellation of partner ILL This commit enables the display of the "Revert request" button when a request's status is GENREQ / "Requested from partners" The relevant unit test has also been updated Rescued-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Created attachment 150642 [details] [review] Bug 27542: (follow-up) Capitalization Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Created attachment 150643 [details] [review] Bug 27542: (follow-up) Fix unit test Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Added SO lines from customers using this in production. My feeling is we should go straight to PQA here.. the code is well and truly tested and working. Created attachment 151458 [details] [review] Bug 27542: Allow cancellation of partner ILL This commit enables the display of the "Revert request" button when a request's status is GENREQ / "Requested from partners" The relevant unit test has also been updated Rescued-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Created attachment 151459 [details] [review] Bug 27542: (follow-up) Capitalization Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Created attachment 151460 [details] [review] Bug 27542: (follow-up) Fix unit test Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Pushed to master for 23.11. Nice work everyone, thanks! Enhancement not backported to 23.05.x |