Summary: | Simplify /checkouts implementation | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | REST API | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | caroline.cyr-la-rose, jonathan.druart, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.05.00
|
|
Circulation function: | |||
Bug Depends on: | 17005 | ||
Bug Blocks: | 27353 | ||
Attachments: |
Bug 27544: Simplilfy GET /checkouts implementation
Bug 27544: Simplilfy GET /checkouts implementation Bug 27544: Simplify GET /checkouts implementation Bug 27544: Simplify GET /checkouts implementation |
Description
Tomás Cohen Arazi (tcohen)
2021-01-25 13:32:19 UTC
Created attachment 115770 [details] [review] Bug 27544: Simplilfy GET /checkouts implementation This patch makes the list() controller method simpler, by removing the checked_in parameter, and passing the appropriate restulset. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/checkouts.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat (1) => SUCCESS: Tests still pass! (no behaviour change) 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 115772 [details] [review] Bug 27544: Simplilfy GET /checkouts implementation This patch makes the list() controller method simpler, by removing the checked_in parameter, and passing the appropriate restulset. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/checkouts.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat (1) => SUCCESS: Tests still pass! (no behaviour change) 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 115773 [details] [review] Bug 27544: Simplify GET /checkouts implementation This patch makes the list() controller method simpler, by removing the checked_in parameter, and passing the appropriate restulset. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/checkouts.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat (1) => SUCCESS: Tests still pass! (no behaviour change) 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 115778 [details] [review] Bug 27544: Simplify GET /checkouts implementation This patch makes the list() controller method simpler, by removing the checked_in parameter, and passing the appropriate restulset. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/checkouts.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat (1) => SUCCESS: Tests still pass! (no behaviour change) 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Nice cleanup, works as expected.. Passing QA Pushed to master for 21.05, thanks to everybody involved! |