| Summary: | Searchid not initialized when adding a new record | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Cataloging | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | andrew, fridolin.somers, kyle, m.de.rooy, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.05.00,20.11.04,20.05.10
|
|
| Circulation function: | |||
| Attachments: |
Bug 27578: Initialize searchid as blank when not populated
Bug 27578: Initialize searchid as blank when not populated Bug 27578: Initialize searchid as blank when not populated |
||
|
Description
Nick Clemens (kidclamp)
2021-01-29 13:47:09 UTC
Created attachment 116031 [details] [review] Bug 27578: Initialize searchid as blank when not populated This patch simply sets the searchid to a blank string if not passed in To test: 1 - Add a new biblio and save it 2 - Check the logs: /var/log/koha/kohadev/plack-intranet-error.log (or similar) 3 - Note warn about uninitialized value 4 - Apply patch 5 - Add a new biblio 6 - No warn Created attachment 117238 [details] [review] Bug 27578: Initialize searchid as blank when not populated This patch simply sets the searchid to a blank string if not passed in To test: 1 - Add a new biblio and save it 2 - Check the logs: /var/log/koha/kohadev/plack-intranet-error.log (or similar) 3 - Note warn about uninitialized value 4 - Apply patch 5 - Add a new biblio 6 - No warn Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Created attachment 117366 [details] [review] Bug 27578: Initialize searchid as blank when not populated This patch simply sets the searchid to a blank string if not passed in To test: 1 - Add a new biblio and save it 2 - Check the logs: /var/log/koha/kohadev/plack-intranet-error.log (or similar) 3 - Note warn about uninitialized value 4 - Apply patch 5 - Add a new biblio 6 - No warn Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 21.05, thanks to everybody involved! In my opinion we should use q{} for empty strings.
Pushed to 20.11.x for 20.11.04 Pushed to 20.05.x for 20.05.10 Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. |