Description
Owen Leonard
2021-02-02 16:13:23 UTC
Created attachment 116221 [details] [review] Bug 27598: Add UPLOAD as a built-in system authorized value category This patch updates the database so that it includes an "UPLOAD" authorized value category with the "is_system" flag set to 1. The upload tool template is updated to add a link to the authorized value category from the hint which appears if no authorized values exist in the UPLOAD category. To test, apply the patch and run the database update. - If you have manually added an UPLOAD category it should now be classified as a system category. - If you did not have an UPLOAD category it should have been created for you. - With no authorized values in the UPLOAD category, go to Tools -> Upload. - Logged in as a user with permission to manage authorized values you should see a note, "No upload categories are defined..." It should contain a link directly to the UPLOAD category of authorized values. - Logged in as a user without authorized value permission you should see a similar note without the link. - Add an authorized value in the UPLOAD category and confirm that the note disappears. Created attachment 116428 [details] [review] Bug 27598: Add UPLOAD as a built-in system authorized value category This patch updates the database so that it includes an "UPLOAD" authorized value category with the "is_system" flag set to 1. The upload tool template is updated to add a link to the authorized value category from the hint which appears if no authorized values exist in the UPLOAD category. To test, apply the patch and run the database update. - If you have manually added an UPLOAD category it should now be classified as a system category. - If you did not have an UPLOAD category it should have been created for you. - With no authorized values in the UPLOAD category, go to Tools -> Upload. - Logged in as a user with permission to manage authorized values you should see a note, "No upload categories are defined..." It should contain a link directly to the UPLOAD category of authorized values. - Logged in as a user without authorized value permission you should see a similar note without the link. - Add an authorized value in the UPLOAD category and confirm that the note disappears. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Created attachment 116447 [details] [review] Bug 27598: Add UPLOAD as a built-in system authorized value category This patch updates the database so that it includes an "UPLOAD" authorized value category with the "is_system" flag set to 1. The upload tool template is updated to add a link to the authorized value category from the hint which appears if no authorized values exist in the UPLOAD category. To test, apply the patch and run the database update. - If you have manually added an UPLOAD category it should now be classified as a system category. - If you did not have an UPLOAD category it should have been created for you. - With no authorized values in the UPLOAD category, go to Tools -> Upload. - Logged in as a user with permission to manage authorized values you should see a note, "No upload categories are defined..." It should contain a link directly to the UPLOAD category of authorized values. - Logged in as a user without authorized value permission you should see a similar note without the link. - Add an authorized value in the UPLOAD category and confirm that the note disappears. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> This works well for the existing installations, but won't add the value to new installations. Can you please also add it to: https://git.koha-community.org/Koha-community/Koha/src/branch/master/installer/data/mysql/mandatory/auth_val_cat.sql And write up a short description for the authorised value categories table? Created attachment 116502 [details] [review] Bug 27598: (QA follow-up) Add category description and installer data This follow-up makes two additions: - The UPLOAD category is added to auth_val_cat.sql for new installations. - A description of the category is added to the authorized values template. Created attachment 116860 [details] [review] Bug 27598: Add UPLOAD as a built-in system authorized value category This patch updates the database so that it includes an "UPLOAD" authorized value category with the "is_system" flag set to 1. The upload tool template is updated to add a link to the authorized value category from the hint which appears if no authorized values exist in the UPLOAD category. To test, apply the patch and run the database update. - If you have manually added an UPLOAD category it should now be classified as a system category. - If you did not have an UPLOAD category it should have been created for you. - With no authorized values in the UPLOAD category, go to Tools -> Upload. - Logged in as a user with permission to manage authorized values you should see a note, "No upload categories are defined..." It should contain a link directly to the UPLOAD category of authorized values. - Logged in as a user without authorized value permission you should see a similar note without the link. - Add an authorized value in the UPLOAD category and confirm that the note disappears. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 116861 [details] [review] Bug 27598: (QA follow-up) Add category description and installer data This follow-up makes two additions: - The UPLOAD category is added to auth_val_cat.sql for new installations. - A description of the category is added to the authorized values template. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Thx for the follow-up! Pushed to master for 21.05, thanks to everybody involved! |