| Summary: | Add floating toolbar to patron search page | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | caroline.cyr-la-rose, fridolin.somers, jonathan.druart |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This patch modifies the patron module's search interface so that the toolbar of results-related controls sticks to the top of the screen as the user scrolls down. This
gives access to the controls for adding patrons to a list and for merging patrons.
|
Version(s) released in: |
21.05.00
|
| Circulation function: | |||
| Bug Depends on: | 27403 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 27605: Add floating toolbar to patron search page
Bug 27605: Add floating toolbar to patron search page Bug 27605: Add floating toolbar to patron search page Bug 27605: (follow-up) Make the feature work with Bug 27403 |
||
|
Description
Owen Leonard
2021-02-03 15:28:43 UTC
Created attachment 116283 [details] [review] Bug 27605: Add floating toolbar to patron search page This patch modifies the patron search results page so that the toolbar with results-related controls "floats" when the user scrolls down. This gives access to the controls for adding patrons to a list and for merging patrons. Other templates are modified to incorporate a change to the CSS which changes "#searchheader" to ".searchheader," enabling multiple instances of a <div> styled with the .searchheader class. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Patrons in the staff interface. - Perform a patron search which will return many results. - Scroll down the page far enough to trigger the floating toolbar. - Confirm that the toolbar is positioned correctly when paging through results. - Confirm that the patron list and merge controls still work correctly. - Confirm that other pages which used the "#searchheader" id are still styled correctly: - Catalog search results - List contents - Patron list contents - Add orders from MARC file Created attachment 116289 [details] [review] Bug 27605: Add floating toolbar to patron search page This patch modifies the patron search results page so that the toolbar with results-related controls "floats" when the user scrolls down. This gives access to the controls for adding patrons to a list and for merging patrons. Other templates are modified to incorporate a change to the CSS which changes "#searchheader" to ".searchheader," enabling multiple instances of a <div> styled with the .searchheader class. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Patrons in the staff interface. - Perform a patron search which will return many results. - Scroll down the page far enough to trigger the floating toolbar. - Confirm that the toolbar is positioned correctly when paging through results. - Confirm that the patron list and merge controls still work correctly. - Confirm that other pages which used the "#searchheader" id are still styled correctly: - Catalog search results - List contents - Patron list contents - Add orders from MARC file Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 116446 [details] [review] Bug 27605: Add floating toolbar to patron search page This patch modifies the patron search results page so that the toolbar with results-related controls "floats" when the user scrolls down. This gives access to the controls for adding patrons to a list and for merging patrons. Other templates are modified to incorporate a change to the CSS which changes "#searchheader" to ".searchheader," enabling multiple instances of a <div> styled with the .searchheader class. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Patrons in the staff interface. - Perform a patron search which will return many results. - Scroll down the page far enough to trigger the floating toolbar. - Confirm that the toolbar is positioned correctly when paging through results. - Confirm that the patron list and merge controls still work correctly. - Confirm that other pages which used the "#searchheader" id are still styled correctly: - Catalog search results - List contents - Patron list contents - Add orders from MARC file Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> I was a little surprised that the "second" toolbar was the floating one, not the one with "Patron lists" and "New patron". But the ones floating make more sense. I've marked this one dependent, can it be fixed? Created attachment 116528 [details] [review] Bug 27605: (follow-up) Make the feature work with Bug 27403 This patch adds the "fh-fixedHeader" class to the floating toolbar so that the floating DataTable header knows what element to append itself to. Not blocker, just noting: there is a very small shift (right/left): https://snipboard.io/LuA9Td.jpg Pushed to master for 21.05, thanks to everybody involved! Enhancement not pushed to 20.11.x |
