Summary: | misc/cronjobs/longoverdue.pl better error message | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | Command-line Utilities | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | andrew, david, jonathan.druart, martin.renvoize, robin, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | String patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
21.05.00,20.11.05,20.05.11
|
Circulation function: | |
Attachments: |
Bug 27656: misc/cronjobs/longoverdue.pl better error message
Bug 27656: misc/cronjobs/longoverdue.pl better error message Bug 27656: misc/cronjobs/longoverdue.pl better error message Bug 27656: misc/cronjobs/longoverdue.pl better error message |
Description
Fridolin Somers
2021-02-08 14:27:12 UTC
Created attachment 116510 [details] [review] Bug 27656: misc/cronjobs/longoverdue.pl better error message There are two ways of configuring misc/cronjobs/longoverdue.pl : use --lost arg or system preferencies DefaultLongOverdueLostValue and DefaultLongOverdueDays. Actually if you don't use any of it, you get a message : "ERROR: No --lost (-l) option defined" Should also say something about preferencies : "ERROR: No --lost (-l) option nor system preferencies DefaultLongOverdueLostValue/DefaultLongOverdueDays defined" Test plan: 1) Set empty preferences DefaultLongOverdueLostValue and DefaultLongOverdueDays 2) Run : misc/cronjobs/longoverdue.pl --maxdays 365 3) You see error message 4) Set DefaultLongOverdueLostValue = 1 and DefaultLongOverdueDays = 90 5) Run : misc/cronjobs/longoverdue.pl --maxdays 365 6) You don't see error message Created attachment 119093 [details] [review] Bug 27656: misc/cronjobs/longoverdue.pl better error message There are two ways of configuring misc/cronjobs/longoverdue.pl : use --lost arg or system preferencies DefaultLongOverdueLostValue and DefaultLongOverdueDays. Actually if you don't use any of it, you get a message : "ERROR: No --lost (-l) option defined" Should also say something about preferencies : "ERROR: No --lost (-l) option nor system preferencies DefaultLongOverdueLostValue/DefaultLongOverdueDays defined" Test plan: 1) Set empty preferences DefaultLongOverdueLostValue and DefaultLongOverdueDays 2) Run : misc/cronjobs/longoverdue.pl --maxdays 365 3) You see error message 4) Set DefaultLongOverdueLostValue = 1 and DefaultLongOverdueDays = 90 5) Run : misc/cronjobs/longoverdue.pl --maxdays 365 6) You don't see error message Signed-off-by: David Nind <david@davidnind.com> A minor suggestion would be to change the error message from: ..option nor system preferencies.. to ..option or system preferences.. Please address David's suggestion. Created attachment 119707 [details] [review] Bug 27656: misc/cronjobs/longoverdue.pl better error message There are two ways of configuring misc/cronjobs/longoverdue.pl : use --lost arg or system preferencies DefaultLongOverdueLostValue and DefaultLongOverdueDays. Actually if you don't use any of it, you get a message : "ERROR: No --lost (-l) option defined" Should also say something about preferencies : "ERROR: No --lost (-l) option no system preferences DefaultLongOverdueLostValue/DefaultLongOverdueDays defined" Test plan: 1) Set empty preferences DefaultLongOverdueLostValue and DefaultLongOverdueDays 2) Run : misc/cronjobs/longoverdue.pl --maxdays 365 3) You see error message 4) Set DefaultLongOverdueLostValue = 1 and DefaultLongOverdueDays = 90 5) Run : misc/cronjobs/longoverdue.pl --maxdays 365 6) You don't see error message Signed-off-by: David Nind <david@davidnind.com> (In reply to Jonathan Druart from comment #4) > Please address David's suggestion. Sure. My english is sometimes rusty ;) Created attachment 119744 [details] [review] Bug 27656: misc/cronjobs/longoverdue.pl better error message There are two ways of configuring misc/cronjobs/longoverdue.pl : use --lost arg or system preferencies DefaultLongOverdueLostValue and DefaultLongOverdueDays. Actually if you don't use any of it, you get a message : "ERROR: No --lost (-l) option defined" Should also say something about preferencies : "ERROR: No --lost (-l) option no system preferences DefaultLongOverdueLostValue/DefaultLongOverdueDays defined" Test plan: 1) Set empty preferences DefaultLongOverdueLostValue and DefaultLongOverdueDays 2) Run : misc/cronjobs/longoverdue.pl --maxdays 365 3) You see error message 4) Set DefaultLongOverdueLostValue = 1 and DefaultLongOverdueDays = 90 5) Run : misc/cronjobs/longoverdue.pl --maxdays 365 6) You don't see error message Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.05 Pushed to 20.05.x for 20.05.11 Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. |