| Summary: | Place hold link for individual OPAC search result broken | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | fridolin.somers, martin.renvoize, phil |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.05.00
|
|
| Circulation function: | |||
| Bug Depends on: | 27440 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 27731: Remove hold class from individual OPAC search result hold link
Bug 27731: Remove hold class from individual OPAC search result hold link Bug 27731: Remove hold class from individual OPAC search result hold link |
||
|
Description
Owen Leonard
2021-02-19 11:41:35 UTC
Created attachment 117061 [details] [review] Bug 27731: Remove hold class from individual OPAC search result hold link This patch removes the "hold" class from the "Place hold" link associated with each search result in the OPAC. The class isn't required for any functionality or style and it unintentionally triggers the "hold multiple" JS function which requires that a checkbox be checked. To test, apply the patch and log into the OPAC as a user who can place holds. - Perform a catalog search which will return multiple results. - Click the "Place hold" link under any search result. - You should be taken to the hold confirmation page. - On the search results page, confirm that the "Place hold" link at the top of the search results still works to place multiple holds at once. Created attachment 117092 [details] [review] Bug 27731: Remove hold class from individual OPAC search result hold link This patch removes the "hold" class from the "Place hold" link associated with each search result in the OPAC. The class isn't required for any functionality or style and it unintentionally triggers the "hold multiple" JS function which requires that a checkbox be checked. To test, apply the patch and log into the OPAC as a user who can place holds. - Perform a catalog search which will return multiple results. - Click the "Place hold" link under any search result. - You should be taken to the hold confirmation page. - On the search results page, confirm that the "Place hold" link at the top of the search results still works to place multiple holds at once. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Created attachment 117160 [details] [review] Bug 27731: Remove hold class from individual OPAC search result hold link This patch removes the "hold" class from the "Place hold" link associated with each search result in the OPAC. The class isn't required for any functionality or style and it unintentionally triggers the "hold multiple" JS function which requires that a checkbox be checked. To test, apply the patch and log into the OPAC as a user who can place holds. - Perform a catalog search which will return multiple results. - Click the "Place hold" link under any search result. - You should be taken to the hold confirmation page. - On the search results page, confirm that the "Place hold" link at the top of the search results still works to place multiple holds at once. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Works as expected, trivial fix. Passing QA Pushed to master for 21.05, thanks to everybody involved! |