| Summary: | Correct eslint errors in basket.js | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | andrew, david, fridolin.somers, testopia, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This patch makes minor changes to basket.js in the staff interface templates to remove ESLint warnings. Besides whitespace changes, most changes are to correct undeclared or unnecessarily declared variables.
|
Version(s) released in: |
21.05.00,20.11.04,20.05.10
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 23833 | ||
| Attachments: |
Bug 27754: Correct eslint errors in basket.js
Bug 27754: Correct eslint errors in basket.js Bug 27754: Correct eslint errors in basket.js |
||
|
Description
Owen Leonard
2021-02-22 17:43:01 UTC
Created attachment 117173 [details] [review] Bug 27754: Correct eslint errors in basket.js This patch makes minor changes to basket.js in the staff interface templates in order to quiet warnings from ESLint. Besides whitespace, most changes are to correct undeclared or unnecessarily declared variables. To test, apply the patch and verify that the cart still works correctly. - Perform a catalog search in the staff interface. - Test adding single or multiple items to the cart from the search results page. - Testing adding and removing titles to the cart from the bibliographic detail page. - Open the cart and test the various controls in the toolbar to confirm that they still work correctly. Created attachment 117229 [details] [review] Bug 27754: Correct eslint errors in basket.js This patch makes minor changes to basket.js in the staff interface templates in order to quiet warnings from ESLint. Besides whitespace, most changes are to correct undeclared or unnecessarily declared variables. To test, apply the patch and verify that the cart still works correctly. - Perform a catalog search in the staff interface. - Test adding single or multiple items to the cart from the search results page. - Testing adding and removing titles to the cart from the bibliographic detail page. - Open the cart and test the various controls in the toolbar to confirm that they still work correctly. Signed-off-by: David Nind <david@davidnind.com> Have added Bug 27767 - if you use batch delete from a cart, the number of items shown in the cart menu item don't reduce, but the items are removed from the cart. This behaviour was exhibited before the patch was applied. Also, no ESLint warnings or errors identified using the Atom text editor and the linter-eslint package. Created attachment 117419 [details] [review] Bug 27754: Correct eslint errors in basket.js This patch makes minor changes to basket.js in the staff interface templates in order to quiet warnings from ESLint. Besides whitespace, most changes are to correct undeclared or unnecessarily declared variables. To test, apply the patch and verify that the cart still works correctly. - Perform a catalog search in the staff interface. - Test adding single or multiple items to the cart from the search results page. - Testing adding and removing titles to the cart from the bibliographic detail page. - Open the cart and test the various controls in the toolbar to confirm that they still work correctly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.04 Pushed to 20.05.x for 20.05.10 Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. |