Bug 27790

Summary:	Possibility to filter Holds to pull list using pickup place
Product:	Koha	Reporter:	Peter Vashchuk <stalkernoid>
Component:	Hold requests	Assignee:	Peter Vashchuk <stalkernoid>
Status:	CLOSED FIXED	QA Contact:	Kyle M Hall (khall) <kyle>
Severity:	enhancement
Priority:	P5 - low	CC:	fridolin.somers, gmcharlt, joonas.kylmala, kyle.m.hall, kyle, nugged
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Small patch
Documentation contact:		Documentation submission:
Text to go in the release notes:	Add option to filter by pickup location in Holds to pull report.	Version(s) released in:	21.05.00
Circulation function:
Attachments:	Bug 27790: separate earliest hold date into two different columns Bug 27790: separate earliest hold date into two different columns Bug 27790: separate earliest hold date into two different columns Bug 27790: (QA follow-up) Fix offsets due to new columns Bug 27790: Add the new column to columns_settings.yml

Description Peter Vashchuk 2021-02-25 10:25:42 UTC

Finnish libraries that we're supporting are actively using holds-to-pull feature, according to their reports, having  ability to filter the table by "Pickup place" will help them be more efficient, as they often process those holds in batches by pickup places. They already tested that in the modified older version of Koha, and with plugin as well, which proved that they definitely need this feature and it helps libraries a lot.

External reference for this request from Finnish libraries: 
https://tiketti.koha-suomi.fi/issues/4537

Comment 1 Peter Vashchuk 2021-02-25 10:29:44 UTC

Created attachment 117305 [details] [review]
Bug 27790: separate earliest hold date into two different columns

Currently "Earliest hold date" and "Pickup place" are displayed
in one single column, but to make filtering possible it is necessary
to split those fields into separate ones.
This patch does exactly that and adds sorting list drop down feature to
the "Pickup place" column.

To reproduce:
    1) Make a few holds and head over to "Circulations->Holds to pull".
    2) Ensure that pickup place and earliest hold date are
in the same column "Earliest hold date"
    3) Apply the patch.
    4) Check "Circulations->Holds to pull list" again, this time
booking date and pickup place should have their own columns.
Ensure that filtering by "pickup location" works fine.

Comment 2 Owen Leonard 2021-02-25 14:52:45 UTC

Created attachment 117332 [details] [review]
Bug 27790: separate earliest hold date into two different columns

Currently "Earliest hold date" and "Pickup place" are displayed
in one single column, but to make filtering possible it is necessary
to split those fields into separate ones.
This patch does exactly that and adds sorting list drop down feature to
the "Pickup place" column.

To reproduce:
    1) Make a few holds and head over to "Circulations->Holds to pull".
    2) Ensure that pickup place and earliest hold date are
in the same column "Earliest hold date"
    3) Apply the patch.
    4) Check "Circulations->Holds to pull list" again, this time
booking date and pickup place should have their own columns.
Ensure that filtering by "pickup location" works fine.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Comment 3 Kyle M Hall (khall) 2021-04-23 17:11:46 UTC

Created attachment 120123 [details] [review]
Bug 27790: separate earliest hold date into two different columns

Currently "Earliest hold date" and "Pickup place" are displayed
in one single column, but to make filtering possible it is necessary
to split those fields into separate ones.
This patch does exactly that and adds sorting list drop down feature to
the "Pickup place" column.

To reproduce:
    1) Make a few holds and head over to "Circulations->Holds to pull".
    2) Ensure that pickup place and earliest hold date are
in the same column "Earliest hold date"
    3) Apply the patch.
    4) Check "Circulations->Holds to pull list" again, this time
booking date and pickup place should have their own columns.
Ensure that filtering by "pickup location" works fine.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Comment 4 Kyle M Hall (khall) 2021-04-23 17:12:00 UTC

Created attachment 120124 [details] [review]
Bug 27790: (QA follow-up) Fix offsets due to new columns

Comment 5 Jonathan Druart 2021-04-27 13:38:54 UTC

Created attachment 120229 [details] [review]
Bug 27790: Add the new column to columns_settings.yml

Comment 6 Jonathan Druart 2021-04-27 14:25:50 UTC

Pushed to master for 21.05, thanks to everybody involved!

Comment 7 Fridolin Somers 2021-04-30 09:02:01 UTC

Enhancement not pushed to 20.11.x