Summary: | Store Contents of FTX segment of EDI quotes for inclusion in orders | ||
---|---|---|---|
Product: | Koha | Reporter: | Colin Campbell <colin.campbell> |
Component: | Acquisitions | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
Status: | CLOSED FIXED | QA Contact: | Kyle M Hall (khall) <kyle> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers, janet.mcgowan, jonathan.druart, kyle, martin.renvoize, nick, victor, wainuiwitikapark |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This enhancement adds support for the EDI FTX (FreeText) segment in Edifact ordering. We simply store the segment and pass it around in the EDI process required.
|
Version(s) released in: |
21.05.00,20.11.15
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 35311 | ||
Attachments: |
Patch to save Quote FTX segment and to include it outgoing order
Bug 27793: Store FTX free text in vendor note Bug 27793: Store FTX free text in vendor note Bug 27793: Store FTX free text in vendor note |
Description
Colin Campbell
2021-02-25 12:28:32 UTC
Created attachment 117307 [details] [review] Patch to save Quote FTX segment and to include it outgoing order Created attachment 117556 [details] [review] Bug 27793: Store FTX free text in vendor note This is important for proquest ordering to distinguish types of material. FTX segment from quote is stored as vendor note. Contents of vendornote are included in the order FTX segment. Created attachment 118743 [details] [review] Bug 27793: Store FTX free text in vendor note This is important for proquest ordering to distinguish types of material. FTX segment from quote is stored as vendor note. Contents of vendornote are included in the order FTX segment. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Moving directly to PQA. Unit tests are missing. I don't think we should continue to add new enhancements to EDI without test coverage. I've struggled to write a test here.. I think it would be great to integrate this for this cycle, and I'll try to work through tests for EDI as a more thorough job as a roadmap task during the next cycle.. does that sound reasonable Jonathan? Please rebase on top of bug 26989. The conflict seems trivial but I don't want to mess with this code (or even touch it). Created attachment 120483 [details] [review] Bug 27793: Store FTX free text in vendor note This is important for proquest ordering to distinguish types of material. FTX segment from quote is stored as vendor note. Contents of vendornote are included in the order FTX segment. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Last time I am pushing an EDI enhancement without test coverage. Pushed to master for 21.05, thanks to everybody involved! Enhancement not pushed to 20.11.x *** Bug 18637 has been marked as a duplicate of this bug. *** Surprise backport! Backported: Pushed to 20.11.x branch for 20.11.15 It's for bug 29670 comment 20 Do I need to backport this to 19.11.x? I probably won't unless there is a need for it It depends indirectly on bug 27708 so no need for 19.11.x Not backported to 19.11.x |