| Summary: | Misalignment of TOTAL value in lateorders page | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Séverine Queune <severine.queune> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | andrew, fridolin.somers, martin.renvoize, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.05.00,20.11.04,20.05.10
|
|
| Circulation function: | |||
| Attachments: |
Bad alignment of Total cost sum
Bug 27795: Misalignment of TOTAL value in lateorders page Bug 27795: Misalignment of TOTAL value in lateorders page Bug 27795: Misalignment of TOTAL value in lateorders page |
||
Created attachment 117331 [details] [review] Bug 27795: Misalignment of TOTAL value in lateorders page This patch corrects the colspan in the footer of the late orders page. It also adds a quantity total cell to the footer and changes the container of the buttons at the bottom of the page from a <p> tag to the standard <fieldset class="action">. To test, apply the patch and go to Acquisitions -> Late orders. In the footer of the late orders page, there should be a total under the "Quantity" column. The total cost number should be correctly aligned under the "total cost" header cell. Created attachment 117431 [details] [review] Bug 27795: Misalignment of TOTAL value in lateorders page This patch corrects the colspan in the footer of the late orders page. It also adds a quantity total cell to the footer and changes the container of the buttons at the bottom of the page from a <p> tag to the standard <fieldset class="action">. To test, apply the patch and go to Acquisitions -> Late orders. In the footer of the late orders page, there should be a total under the "Quantity" column. The total cost number should be correctly aligned under the "total cost" header cell. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Looks good, signing off. Created attachment 117732 [details] [review] Bug 27795: Misalignment of TOTAL value in lateorders page This patch corrects the colspan in the footer of the late orders page. It also adds a quantity total cell to the footer and changes the container of the buttons at the bottom of the page from a <p> tag to the standard <fieldset class="action">. To test, apply the patch and go to Acquisitions -> Late orders. In the footer of the late orders page, there should be a total under the "Quantity" column. The total cost number should be correctly aligned under the "total cost" header cell. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.04 Pushed to 20.05.x for 20.05.10 Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. |
Created attachment 117323 [details] Bad alignment of Total cost sum On /cgi-bin/koha/acqui/lateorders.pl page, the "Total cost" sum is align with the quantity column. It should be shift by a column to the right (sees screenshot attached). Maybe the occasion to add a total for "Quantity" column ?