|
Description
Barbara Johnson
2021-02-26 22:22:07 UTC
Created attachment 118969 [details] [review] Bug 27817: Use biblio-title include in some acquisitions pages This patch adds the use of the biblio-title include in acquisitions templates which get the right data from their corresponding scripts. To test, apply the patch and test these Acquisitions pages to confirm that titles with 245$b, 245$h, etc, show all the correct information. - Acquisitions -> Vendor -> Basket - Acquisitions -> Vendor -> Uncertain prices - Acquisitions -> Invoices -> Invoice - Acquisitions -> Invoices -> Invoice -> View an invoice which has an already-received bibliographic record. - Go to receipt page -> Already received. -- The "Pending orders" table is unmodified because I wasn't sure how to use the biblio-title include in an AJAX DataTable. *** Bug 20532 has been marked as a duplicate of this bug. *** I tested in a sandbox. For Acquisitions -> Vendor -> Basket I'm getting a "Template process failed" error. For all other pages I'm not seeing the additional info from the 245$b, 245$h, 245$n or 245$p subfields. Thanks for testing, Barbara. Please feel free to mark something "Failed QA" if anything doesn't work. It's not a setting which is reserved for the QA team. Because this was still "needs signoff" I didn't realize there was a problem with it! Created attachment 126323 [details] [review] Bug 27817: Use biblio-title include in some acquisitions pages This patch adds the use of the biblio-title include in acquisitions templates which get the right data from their corresponding scripts. To test, apply the patch and test these Acquisitions pages to confirm that titles with 245$b, 245$h, etc, show all the correct information. - Acquisitions -> Vendor -> Basket - Acquisitions -> Vendor -> Uncertain prices - Acquisitions -> Invoices -> Invoice - Acquisitions -> Invoices -> Invoice -> View an invoice which has an already-received bibliographic record. - Go to receipt page -> Already received. -- The "Pending orders" table is unmodified because I wasn't sure how to use the biblio-title include in an AJAX DataTable. I couldn't (In reply to Barbara Johnson from comment #3) > I tested in a sandbox. For Acquisitions -> Vendor -> Basket I'm getting a > "Template process failed" error. I couldn't reproduce this error, but the patch needed to be rebased so a new version is attached. Here's what I have found so far in my testing: On basket.pl the title and subtitle display correctly in the 245|a and 245|b. However, it is also incorrectly including series data from the 490|a and 490|v. See the attachment acq_basket.png. The info highlighted in yellow is coming from the 490 tag. On ordered.pl only data from the 245|a is displaying. See the attachment acq_ordered.png. Each title that has been highlighted has a subtitle in the 245|b but it is not displaying. On orderreceive.pl, parcel.pl and invoice.pl the 245|a and 245|b display correctly. Actually parcel.pl is the the place the extra info from the 245|b would be most useful. I attached a screenshot (which_wimpy_kid_is_it.png) showing the display a staff person sees when receiving. In the example all four books are different wimpy kid titles, but without the subtitle displayed it's not readily apparent which is the correct book to receive. Staff then has to start looking at the ISBNS which is more time consuming. Created attachment 130899 [details]
acq_basket
Created attachment 130900 [details]
acq_ordered
Created attachment 130901 [details]
wimpy kid
Owen, could you have a look at Barbara's comments please? (In reply to Barbara Johnson from comment #7) > On basket.pl ... is also incorrectly including series data from the 490|a and > 490|v. basket.pl and invoice.pl have code to deliberately add the series information to the title variable: if ( $line{'title'} ) { my $volume = $order->{'volume'}; my $seriestitle = $order->{'seriestitle'}; $line{'title'} .= " / $seriestitle" if $seriestitle; $line{'title'} .= " / $volume" if $volume; } parcel.pl appears to be showing 245$b correctly for me in the "Already received" table, which is the only place this patch changes anything. The display of title information in the "Pending orders" table is not affected. Created attachment 139517 [details] [review] Bug 27817: Use biblio-title include in some acquisitions pages This patch adds the use of the biblio-title include in acquisitions templates which get the right data from their corresponding scripts. To test, apply the patch and test these Acquisitions pages to confirm that titles with 245$b, 245$h, etc, show all the correct information. - Acquisitions -> Vendor -> Basket - Acquisitions -> Vendor -> Uncertain prices - Acquisitions -> Invoices -> Invoice - Acquisitions -> Invoices -> Invoice -> View an invoice which has an already-received bibliographic record. - Go to receipt page -> Already received. -- The "Pending orders" table is unmodified because I wasn't sure how to use the biblio-title include in an AJAX DataTable. (In reply to Owen Leonard from comment #12) > (In reply to Barbara Johnson from comment #7) > > > On basket.pl ... is also incorrectly including series data from the 490|a and > > 490|v. > > basket.pl and invoice.pl have code to deliberately add the series > information to the title variable: > > if ( $line{'title'} ) { > my $volume = $order->{'volume'}; > my $seriestitle = $order->{'seriestitle'}; > $line{'title'} .= " / $seriestitle" if $seriestitle; > $line{'title'} .= " / $volume" if $volume; > } > > > parcel.pl appears to be showing 245$b correctly for me in the "Already > received" table, which is the only place this patch changes anything. The > display of title information in the "Pending orders" table is not affected. Maybe we could move the series information display to a separate bug. I can see that the code doesn't affect it - neither adding nor removing. Created attachment 139564 [details] [review] Bug 27817: Use biblio-title include in some acquisitions pages This patch adds the use of the biblio-title include in acquisitions templates which get the right data from their corresponding scripts. To test, apply the patch and test these Acquisitions pages to confirm that titles with 245$b, 245$h, etc, show all the correct information. - Acquisitions -> Vendor -> Basket - Acquisitions -> Vendor -> Uncertain prices - Acquisitions -> Invoices -> Invoice - Acquisitions -> Invoices -> Invoice -> View an invoice which has an already-received bibliographic record. - Go to receipt page -> Already received. -- The "Pending orders" table is unmodified because I wasn't sure how to use the biblio-title include in an AJAX DataTable. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> I filed bug 31433 (order from existing) and bug 31434 (order receive) to complete the work here. This is already a huge improvement and important to libraries dealing with a lot of multi-part records and series that can only be differentiated by part number or part name. @Barbara: if you wanted to give this another try we could count my sign-off towards QA. In my latest test, I can confirm that I am able to view the 245abhnp on basket.pl, orderreceive.pl and invoice.pl. Only the 245a info is displayed on parcel.pl and I believe bug 31434 is supposed to address that. Also, only the 245a is displayed on ordered.pl - it would be helpful to see the additional info here as well. Thx Barbara. Do you want to sign-off with the sandboxes? Otherwise I can try to add your sign-off line later. (In reply to Barbara Johnson from comment #17) > In my latest test, I can confirm that I am able to view the 245abhnp on > basket.pl, orderreceive.pl and invoice.pl. > > Only the 245a info is displayed on parcel.pl and I believe bug 31434 is > supposed to address that. It does show, but only after you received something for the received oders, in the second table below the first. Bug 31434 is for the 'unreceiveds' table. > Also, only the 245a is displayed on ordered.pl - it would be helpful to see > the additional info here as well. Could you file that as a separate one? We'd probably want it for the spent too. Created attachment 139679 [details] [review] Bug 27817: Use biblio-title include in some acquisitions pages This patch adds the use of the biblio-title include in acquisitions templates which get the right data from their corresponding scripts. To test, apply the patch and test these Acquisitions pages to confirm that titles with 245$b, 245$h, etc, show all the correct information. - Acquisitions -> Vendor -> Basket - Acquisitions -> Vendor -> Uncertain prices - Acquisitions -> Invoices -> Invoice - Acquisitions -> Invoices -> Invoice -> View an invoice which has an already-received bibliographic record. - Go to receipt page -> Already received. -- The "Pending orders" table is unmodified because I wasn't sure how to use the biblio-title include in an AJAX DataTable. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> I've signed off on this bug - this functionality will be so helpful. Also, I filed bug 31443 (for viewing titles from ordered.pl) and bug 31444 (for viewing titles on spent.pl) to complete the work already done here. Created attachment 140734 [details] [review] Bug 27817: Use biblio-title include in some acquisitions pages This patch adds the use of the biblio-title include in acquisitions templates which get the right data from their corresponding scripts. To test, apply the patch and test these Acquisitions pages to confirm that titles with 245$b, 245$h, etc, show all the correct information. - Acquisitions -> Vendor -> Basket - Acquisitions -> Vendor -> Uncertain prices - Acquisitions -> Invoices -> Invoice - Acquisitions -> Invoices -> Invoice -> View an invoice which has an already-received bibliographic record. - Go to receipt page -> Already received. -- The "Pending orders" table is unmodified because I wasn't sure how to use the biblio-title include in an AJAX DataTable. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 22.11. Nice work everyone, thanks! Excellent! Enhancement will not be backported to 22.05.x series |