Created attachment 117471 [details] [review] Bug 27827: make the 'Authority type:' input field wider When adding a new authority type in the Staff client, the 'Authority type' input field is too narrow. If you enter something like "OOP_CORPUS" inside the textbox, you will have to scroll right and left inside the textbox in order to view its contents. This patch fixes that. Test plan: 1) Try to add a new authority type with name "OOP_CORPUS". Notice how the input field is too narrow and cannot contain the entire string. 2) Apply this patch. 3) Repeat step 1), this time the input field has been widened and can accommodate the entire string. Created attachment 117474 [details] [review] Bug 27827: make the 'Authority type:' input field wider When adding a new authority type in the Staff client, the 'Authority type' input field is too narrow. If you enter something like "OOP_CORPUS" inside the textbox, you will have to scroll right and left inside the textbox in order to view its contents. This patch fixes that. Test plan: 1) Try to add a new authority type with name "OOP_CORPUS". Notice how the input field is too narrow and cannot contain the entire string. 2) Apply this patch. 3) Repeat step 1), this time the input field has been widened and can accommodate the entire string. Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> For me the 10 character strings fits exactly into the input box. Could there be a difference in how different browsers and browser settings influence this? I am not sure we have a guideline about this kind of thing, but it seems also confusing to have a much longer field that stops you from entering more than 10 characters. Adding Owen to see if there is a general guideline we could follow here. Testing with Firefox on macOS I see exactly what is in the screeshot. I think it's a problem especially when using all capital letters. I'm inclined to go with the proposed solution. I think the confusion about the max length could be mitigated by a hint: <div class="hint">10 characters maximum</div> Interesting! Using Firefox on Linux, but it looked quite different. I am fine with Owen's suggestion. Could you add the hint? Thank you both Katrin and Owen for your feedback. I'll add a follow-up patch for the hint ASAP. Created attachment 118741 [details] [review] Bug 27827: (follow-up) add a hint for clarification When adding a new authority type, there is no indication of how big the authority type code can be (auth_types.authtypecode in the DB has a maximum length of 10 characters). This patch fixes that. To test, apply the patch and notice the hint appearing right above the "Authority type:" text box as you add a new authority type: it should display "10 characters maximum" in grey colour. Created attachment 119115 [details] [review] Bug 27827: make the 'Authority type:' input field wider When adding a new authority type in the Staff client, the 'Authority type' input field is too narrow. If you enter something like "OOP_CORPUS" inside the textbox, you will have to scroll right and left inside the textbox in order to view its contents. This patch fixes that. Test plan: 1) Try to add a new authority type with name "OOP_CORPUS". Notice how the input field is too narrow and cannot contain the entire string. 2) Apply this patch. 3) Repeat step 1), this time the input field has been widened and can accommodate the entire string. Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: David Nind <david@davidnind.com> Created attachment 119116 [details] [review] Bug 27827: (follow-up) add a hint for clarification When adding a new authority type, there is no indication of how big the authority type code can be (auth_types.authtypecode in the DB has a maximum length of 10 characters). This patch fixes that. To test, apply the patch and notice the hint appearing right above the "Authority type:" text box as you add a new authority type: it should display "10 characters maximum" in grey colour. Signed-off-by: David Nind <david@davidnind.com> Created attachment 119746 [details] [review] Bug 27827: make the 'Authority type:' input field wider When adding a new authority type in the Staff client, the 'Authority type' input field is too narrow. If you enter something like "OOP_CORPUS" inside the textbox, you will have to scroll right and left inside the textbox in order to view its contents. This patch fixes that. Test plan: 1) Try to add a new authority type with name "OOP_CORPUS". Notice how the input field is too narrow and cannot contain the entire string. 2) Apply this patch. 3) Repeat step 1), this time the input field has been widened and can accommodate the entire string. Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 119747 [details] [review] Bug 27827: (follow-up) add a hint for clarification When adding a new authority type, there is no indication of how big the authority type code can be (auth_types.authtypecode in the DB has a maximum length of 10 characters). This patch fixes that. To test, apply the patch and notice the hint appearing right above the "Authority type:" text box as you add a new authority type: it should display "10 characters maximum" in grey colour. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.06 Pushed to 20.05.x for 20.05.12 Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. |
Created attachment 117470 [details] The 'Authority type:' input field is too narrow When adding a new authority type in the Staff client, the 'Authority type' input field is too narrow. If you enter something like "OOP_CORPUS" inside the textbox, you will have to scroll right and left inside the textbox in order to view its contents (please see the attached screenshot). This, IMHO, is a nuisance, so I'm choosing a Severity of 'minor' for this bug ("The component mostly works, but causes some irritation to users."). I suggest we increase the 'size' property of the HTML input element from 10 to 20 in order to make it twice as wide (thus allowing even the widest of entries to be displayed in their entirety without any scrolling) while the 'maxlength' property will remain at its current value of 10 since the max. number of characters allowed for an authtype in the database is 10.