Bug 27831

Summary: Object Name Inconsistencies
Product: Koha Reporter: Martin Renvoize <martin.renvoize>
Component: Architecture, internals, and plumbingAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: jonathan.druart+koha, kyle, m.de.rooy, nick, tomascohen
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 8976    
Bug Blocks:    

Description Martin Renvoize 2021-03-02 10:55:49 UTC
During the push of bug 8976 we discovered some inconsistencies in Koha::Object class names which lead to duplication.

We need to clarify the situation and move classes around to be consistent.

Current situation:

Koha::Authority::Subfield(s)
Koha::Authority::Tag(s)
Koha::Authority::Type(s)

Koha::Biblio::Metadata(s)

Koha::MarcSubfieldStructure(s)
Koha::AuthSubfieldStructure(s)

In bug 8976 we made a few suggestions

Koha::Framework::Biblio::Subfield(s)
Koha::Framework::Authority::Subfield(s)
Koha::Framework::Biblio::Tag(s)
Koha::Framework::Authority::Tag(s)

OR

Koha::MARC::Biblio::Subfield(s)
Koha::MARC::Authority::Subfield(s)

OR

Koha::Framework::Subfield::Biblio (inheriting from Koha::Framework::Subfield)
Koha::Framework::Subfield::Authority (inheriting from Koha::Framework::Subfield)

Thougts?