| Summary: | Document that CircControl syspref changes which library's calendar to use | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Joonas Kylmälä <joonas.kylmala> |
| Component: | Circulation | Assignee: | Joonas Kylmälä <joonas.kylmala> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | andrew, fridolin.somers, gmcharlt, kyle.m.hall, martin.renvoize, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | String patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.05.00,20.11.06,20.05.12
|
|
| Circulation function: | |||
| Attachments: |
Bug 27836: Document that CirControl changes which calendar is being used
Bug 27836: Document that CirControl changes which calendar is being used Bug 27836: Document that CirControl changes which calendar is being used |
||
|
Description
Joonas Kylmälä
2021-03-02 15:02:53 UTC
Created attachment 117528 [details] [review] Bug 27836: Document that CirControl changes which calendar is being used You can verify that which branch's Koha calendar is being used to calculate fines by reading for example the code in C4::Circulation::_CalculateAndUpdateFine() There you can see that $control_branchcode variable is being passed to C4::Overdues::CalcFine() and if you trace that you will see in the end it decides which branch's calendar to use for calculating chargeable overdue fine days. Created attachment 119334 [details] [review] Bug 27836: Document that CirControl changes which calendar is being used You can verify that which branch's Koha calendar is being used to calculate fines by reading for example the code in C4::Circulation::_CalculateAndUpdateFine() There you can see that $control_branchcode variable is being passed to C4::Overdues::CalcFine() and if you trace that you will see in the end it decides which branch's calendar to use for calculating chargeable overdue fine days. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 119745 [details] [review] Bug 27836: Document that CirControl changes which calendar is being used You can verify that which branch's Koha calendar is being used to calculate fines by reading for example the code in C4::Circulation::_CalculateAndUpdateFine() There you can see that $control_branchcode variable is being passed to C4::Overdues::CalcFine() and if you trace that you will see in the end it decides which branch's calendar to use for calculating chargeable overdue fine days. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.06 Pushed to 20.05.x for 20.05.12 Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. |