|
Description
Lucy Vaux-Harvey
2021-03-03 11:46:36 UTC
Created attachment 120906 [details] [review] Bug 27848: Elasticsearch - include 245b subtitle subfield in the default title index mappings This patchset adds 245$b (subtitle) and 245$p (part name) to the default title index mappings. To test: 1) Apply patch 2) Reindex using rebuildelasticsearch.pl 3) Search for a subtitle or part name using the title index Created attachment 120907 [details] [review] Bug 27848: Elasticsearch - include 245p to default title index mappings This is a comment I've had from clients too. I submitted a patch adding 245$b and a second patch adding 245$p which is the part name in a multipart series (for example in "Kitty cat 2, The return"; "The return" would be in 245$p). This was my first time submitting several patches at once, I hope I did it correctly. Caroline Hi Caroline, thanks for creating a patch for this and adding 245p as well :) I've tested on a sandbox and searching works well but I couldn't see 245b and 245p listed in the Bibliographic records tab of the Elasticsearch configuration. I think they should be listed here for completeness. Hi Lucy, You can see them if you click on "Reset mappings" in the mapping administration page. I think they don't appear right away because the sandbox is created with the current file, THEN the patch is applied, which changes the file. So we have to "refresh" the mappings. To test: 1) Apply patch 2) Reindex using rebuildelasticsearch.pl -r If you don't have access to a terminal (in a sandbox for example) 2a) Go to Administration > Search engine configuration and click "Reset mappings" and confirm 2b) Then reindex 3) Search for a subtitle or part name using the title index Created attachment 121137 [details] [review] Bug 27848: Elasticsearch - include 245b subtitle subfield in the default title index mappings Signed-off-by: David Nind <david@davidnind.com> Created attachment 121138 [details] [review] Bug 27848: Elasticsearch - include 245p to default title index mappings Signed-off-by: David Nind <david@davidnind.com> Created attachment 121422 [details] [review] Bug 27848: Elasticsearch - include 245b subtitle subfield in the default title index mappings Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucy Vaux-Harvey <lucy.vaux-harvey@ptfs-europe.com> Created attachment 121423 [details] [review] Bug 27848: Elasticsearch - include 245p to default title index mappings Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucy Vaux-Harvey <lucy.vaux-harvey@ptfs-europe.com> Tnanks for the help Caroline, signed off now. Created attachment 123170 [details] [review] Bug 27848: Elasticsearch - include 245b subtitle subfield in the default title index mappings Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucy Vaux-Harvey <lucy.vaux-harvey@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 123171 [details] [review] Bug 27848: Elasticsearch - include 245p to default title index mappings Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucy Vaux-Harvey <lucy.vaux-harvey@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 21.11, thanks to everybody involved! |