Description
Nick Clemens (kidclamp)
2021-03-05 17:32:01 UTC
Created attachment 117870 [details] [review] Bug 27885: Populate biblionumbers parameter using biblionumbers array Currently we send $biblionumbers as the parameter, but this is just apassthrough form when a list of biblios is selected for placing a hold If passed a single biblionumber we push it into @biblionumbers and use that for building the biblio loop This patch uses @biblionumbers to avoid sending a blank variable in the URL To test: 1 - On the staff client click 'place hold' for an individual record 2 - Use the form to find a patron 3 - Note the url is: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumbers= 4 - Apply patch 5 - Repeat 6 - The url is now like: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumbers=248 (but with whatever biblionumber you chose) 7 - Perform a search and select multiple biblios and confirm you can place holds as before Created attachment 117871 [details] [review] Bug 27885: Populate biblionumbers parameter using biblionumbers array Currently we send $biblionumbers as the parameter, but this is just apassthrough form when a list of biblios is selected for placing a hold If passed a single biblionumber we push it into @biblionumbers and use that for building the biblio loop This patch uses @biblionumbers to avoid sending a blank variable in the URL To test: 1 - On the staff client click 'place hold' for an individual record 2 - Use the form to find a patron 3 - Note the url is: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumbers= 4 - Apply patch 5 - Repeat 6 - The url is now like: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumbers=248 (but with whatever biblionumber you chose) 7 - Perform a search and select multiple biblios and confirm you can place holds as before Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> For a single hold I end up with: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumbers=114/ For multiple holds with: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumbers=262%2F13%2F&findborrower=&club= Is the / for the single biblionumber intended and the differences in encoding? (In reply to Katrin Fischer from comment #3) > For a single hold I end up with: > http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumbers=114/ > > For multiple holds with: > http://localhost:8081/cgi-bin/koha/reserve/request. > pl?biblionumbers=262%2F13%2F&findborrower=&club= > > Is the / for the single biblionumber intended and the differences in > encoding? The case I am fixing here is - Placing hold from details/holds tab, but it does seem to clear some trailing slashes in other places. There does seem to be an issue with placing holds on multiple bibs for clubs BEFORE PATCH Placing holds from results: Single biblio: -On patron/club search screen: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumbers=248%2F&findborrower=&club= -After selecting patron: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumber=248/ -After selecting club: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumber=248 Multiple biblios: -On patron/club search screen: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumbers=248%2F310%2F&findborrower=&club= -After selecting patron: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumbers=248/310/ -After selecting club: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumber=310 (something going on with ability to place holds, ignore for now) Placing hold on single bib from the details page/holds tab -On patron/club search screen: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumber=248&searchid=scs_1620306233111 -After selecting patron: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumbers= -After selecting club: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumber=248 AFTER PATCH AND RESTART Placing holds from results: Single biblio: -On patron/club search screen: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumbers=248%2F&findborrower=&club= -After selecting patron: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumbers=248 -After selecting club: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumber=248 Multiple biblios: -On patron/club search screen: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumbers=248%2F310%2F&findborrower=&club= -After selecting patron: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumbers=248/310 -After selecting club: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumber=310 (something going on with ability to place holds, ignore for now) Placing hold on single bib from the details page/holds tab -On patron/club search screen: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumber=248&searchid=scs_1620306452277 -After selecting patron: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumbers=248 -After selecting club: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumber=248 Hi Nick, from your last comment#, should this be FQA (as in: Needs more work)? You mention an issue with multi-holds for clubs. I doesn't apply, the conflict looks simple, but setting this one step back to get confirmation. Created attachment 120831 [details] [review] Bug 27885: Populate biblionumbers parameter using biblionumbers array Currently we send $biblionumbers as the parameter, but this is just apassthrough form when a list of biblios is selected for placing a hold If passed a single biblionumber we push it into @biblionumbers and use that for building the biblio loop This patch uses @biblionumbers to avoid sending a blank variable in the URL To test: 1 - On the staff client click 'place hold' for an individual record 2 - Use the form to find a patron 3 - Note the url is: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumbers= 4 - Apply patch 5 - Repeat 6 - The url is now like: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumbers=248 (but with whatever biblionumber you chose) 7 - Perform a search and select multiple biblios and confirm you can place holds as before Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> (In reply to Katrin Fischer from comment #5) > Hi Nick, from your last comment#, should this be FQA (as in: Needs more > work)? You mention an issue with multi-holds for clubs. > > I doesn't apply, the conflict looks simple, but setting this one step back > to get confirmation. This should be good to move forward - the problems you mentioned and the one I found exist before the patch, the patch fixes the cases it is targeting Created attachment 121425 [details] [review] Bug 27885: (follow-up) Use biblionumbers instead of biblionumber in form action for club search This simply matches the code on the patrons search tab (In reply to Nick Clemens from comment #7) > (In reply to Katrin Fischer from comment #5) > > Hi Nick, from your last comment#, should this be FQA (as in: Needs more > > work)? You mention an issue with multi-holds for clubs. > > > > I doesn't apply, the conflict looks simple, but setting this one step back > > to get confirmation. > > This should be good to move forward - the problems you mentioned and the one > I found exist before the patch, the patch fixes the cases it is targeting Turns out it was just the action link the form being weird, functionality was not affected Created attachment 123119 [details] [review] Bug 27885: Populate biblionumbers parameter using biblionumbers array Currently we send $biblionumbers as the parameter, but this is just apassthrough form when a list of biblios is selected for placing a hold If passed a single biblionumber we push it into @biblionumbers and use that for building the biblio loop This patch uses @biblionumbers to avoid sending a blank variable in the URL To test: 1 - On the staff client click 'place hold' for an individual record 2 - Use the form to find a patron 3 - Note the url is: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumbers= 4 - Apply patch 5 - Repeat 6 - The url is now like: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumbers=248 (but with whatever biblionumber you chose) 7 - Perform a search and select multiple biblios and confirm you can place holds as before Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 123120 [details] [review] Bug 27885: (follow-up) Use biblionumbers instead of biblionumber in form action for club search This simply matches the code on the patrons search tab Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 21.11, thanks to everybody involved! Pushed to 21.05.x for 21.05.03 Pushed to 20.11.x for 20.11.09 Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. |