| Summary: | Timestamp in holds log is out of date when a hold is marked as waiting | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Hold requests | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | andrew, fridolin.somers, gmcharlt, jonathan.druart, martin.renvoize, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.05.00,20.11.05,20.05.11
|
|
| Circulation function: | |||
| Attachments: |
Bug 27921: Log correct timestamp for HOLD MODIFY when set waiting
Bug 27921: Log correct timestamp for HOLD MODIFY when set waiting Bug 27921: Log correct timestamp for HOLD MODIFY when set waiting |
||
|
Description
Nick Clemens (kidclamp)
2021-03-10 20:07:00 UTC
Created attachment 118147 [details] [review] Bug 27921: Log correct timestamp for HOLD MODIFY when set waiting The HOLD MODIFY log at the end of ModReserveAffect is not using an up-to-date $hold object. $hold is modified at 1201 $hold->set_waiting($desk_id); But not refreshed before logged (and so the timestamp is not logged correctly). Test plan: Turn on HoldsLog Place an item on hold Check it in to mark it waiting Confirm that the timestamp logged is the one from the check in, not when you created the hold Created attachment 118314 [details] [review] Bug 27921: Log correct timestamp for HOLD MODIFY when set waiting The HOLD MODIFY log at the end of ModReserveAffect is not using an up-to-date $hold object. $hold is modified at 1201 $hold->set_waiting($desk_id); But not refreshed before logged (and so the timestamp is not logged correctly). Test plan: Turn on HoldsLog Place an item on hold Check it in to mark it waiting Confirm that the timestamp logged is the one from the check in, not when you created the hold Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 118813 [details] [review] Bug 27921: Log correct timestamp for HOLD MODIFY when set waiting The HOLD MODIFY log at the end of ModReserveAffect is not using an up-to-date $hold object. $hold is modified at 1201 $hold->set_waiting($desk_id); But not refreshed before logged (and so the timestamp is not logged correctly). Test plan: Turn on HoldsLog Place an item on hold Check it in to mark it waiting Confirm that the timestamp logged is the one from the check in, not when you created the hold Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Good catch, Passing QA Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.05 Pushed to 20.05.x for 20.05.11 Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. |