Description
Tomás Cohen Arazi (tcohen)
2021-03-11 15:11:21 UTC
Created attachment 118168 [details] [review] Bug 27932: Unit tests Created attachment 118169 [details] [review] Bug 27932: Add GET /biblios/:biblio_id/pickup_locations route This patch adds the mentioned route. It does so by: - Adding the new path in paths.json - Adding the full route spec in biblios.json - Adds a controller method that takes care of the task To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/api/v1/biblios.t => SUCCESS: Tests pass! 3. Play with your favourite REST tool. Pay special care to the AllowHoldPolicyOverride syspref and the expected behaviors. => SUCCESS: All works as expected 4. Sign off :-D Created attachment 118172 [details] [review] Bug 27932: Unit tests Created attachment 118173 [details] [review] Bug 27932: Add GET /biblios/:biblio_id/pickup_locations route This patch adds the mentioned route. It does so by: - Adding the new path in paths.json - Adding the full route spec in biblios.json - Adds a controller method that takes care of the task To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/api/v1/biblios.t => SUCCESS: Tests pass! 3. Play with your favourite REST tool. Pay special care to the AllowHoldPolicyOverride syspref and the expected behaviors. => SUCCESS: All works as expected 4. Sign off :-D Created attachment 118216 [details] [review] Bug 27932: Visual feedback on overridden pickup locations when placing hold Created attachment 119715 [details] [review] Bug 27932: Unit tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 119716 [details] [review] Bug 27932: Add GET /biblios/:biblio_id/pickup_locations route This patch adds the mentioned route. It does so by: - Adding the new path in paths.json - Adding the full route spec in biblios.json - Adds a controller method that takes care of the task To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/api/v1/biblios.t => SUCCESS: Tests pass! 3. Play with your favourite REST tool. Pay special care to the AllowHoldPolicyOverride syspref and the expected behaviors. => SUCCESS: All works as expected 4. Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> This all works well, the code reads nicely and it's well tested. QA Scripts are happy too.. I think we can go straight for PQA Pushed to master for 21.05, thanks to everybody involved! Enhancement not pushed to 20.11.x |