| Summary: | Fix missing email in OpacMaintenance page | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Magnus Enger <magnus> |
| Component: | OPAC | Assignee: | Magnus Enger <magnus> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | andrew, david, fridolin.somers, martin.renvoize, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This fixes no email address being shown on the OPAC maintenance page for "site administrator" link (when OpacMaintenance is set). Before this the link was showing as an empty "mailto:" instead of the value of KohaAdminEmailAddress
|
Version(s) released in: |
21.05.00,20.11.05,20.05.11
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 28086 | ||
| Attachments: |
Bug 27940 - Fix missing email in OpacMaintenance page
Bug 27940: Fix missing email in OpacMaintenance page Bug 27940: Fix missing email in OpacMaintenance page |
||
|
Description
Magnus Enger
2021-03-12 10:18:44 UTC
Created attachment 118184 [details] [review] Bug 27940 - Fix missing email in OpacMaintenance page To reproduce: KohaAdminEmailAddress = Some valid email address OpacMaintenance = Show OPAC/cgi-bin/koha/maintenance.pl shows this text: "Koha online catalog is offline for system maintenance. We'll be back soon! If you have any questions, please contact the site administrator." "site administrator" is a link, but it only links to "mailto:", the actual email address from KohaAdminEmailAddress is missing. To test: - Apply the patch - Reload the maintenance page - Click on the "site administrator" link and verify it contains the address from KohaAdminEmailAddress Created attachment 118337 [details] [review] Bug 27940: Fix missing email in OpacMaintenance page To reproduce: KohaAdminEmailAddress = Some valid email address OpacMaintenance = Show OPAC/cgi-bin/koha/maintenance.pl shows this text: "Koha online catalog is offline for system maintenance. We'll be back soon! If you have any questions, please contact the site administrator." "site administrator" is a link, but it only links to "mailto:", the actual email address from KohaAdminEmailAddress is missing. To test: - Apply the patch - Reload the maintenance page - Click on the "site administrator" link and verify it contains the address from KohaAdminEmailAddress Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 118812 [details] [review] Bug 27940: Fix missing email in OpacMaintenance page To reproduce: KohaAdminEmailAddress = Some valid email address OpacMaintenance = Show OPAC/cgi-bin/koha/maintenance.pl shows this text: "Koha online catalog is offline for system maintenance. We'll be back soon! If you have any questions, please contact the site administrator." "site administrator" is a link, but it only links to "mailto:", the actual email address from KohaAdminEmailAddress is missing. To test: - Apply the patch - Reload the maintenance page - Click on the "site administrator" link and verify it contains the address from KohaAdminEmailAddress Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Good catch, Passing QA Pushed to master for 21.05, thanks to everybody involved! I'd like to open a new bug here - could we agree to display the address from ReplytoDefault when set instead of KohaAdminEmailAdress? In some setups the KohaAdminEmailAdress nees to be set to noreply (same known issue as always with some mail servers being very strict about possible spam) Good call Katrin. (In reply to Martin Renvoize from comment #7) > Good call Katrin. I filed bug 28086 :) Pushed to 20.11.x for 20.11.05 Pushed to 20.05.x for 20.05.11 Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. |