| Summary: | Modals on the borrower account page don't validate minimum values | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
| Component: | Fines and fees | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
| Status: | CLOSED FIXED | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | fridolin.somers, oleonard, sally.healey, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.05.00
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 24300 | ||
| Attachments: |
Bug 27967: Add min attribute to borraccount modals
Bug 27967: Add min attribute to borraccount modals Bug 27967: Add min attribute to borraccount modals |
||
|
Description
Martin Renvoize (ashimema)
2021-03-16 16:36:35 UTC
Created attachment 118339 [details] [review] Bug 27967: Add min attribute to borraccount modals This patch adds a min attribute to the form fields of the borrower account page modals to prevent negative values being entered inappropriately. Test plan 1/ Trigger the refund modal from the borrower account page. 2/ Attempt to enter a negative value for the amount to refund and note with the patch applied you face a validation error (without the patch, upon submission of a negative value you will be faced with a server side error) 3/ Trigger the discount modal from the borrower account page. 4/ Attempt to enter a negative value for the amount to discount and note with the patch applied you face a validation error (without the patch, upon submission of a negative value you will be faced with a server side error) 5/ Signoff Created attachment 118426 [details] [review] Bug 27967: Add min attribute to borraccount modals This patch adds a min attribute to the form fields of the borrower account page modals to prevent negative values being entered inappropriately. Test plan 1/ Trigger the refund modal from the borrower account page. 2/ Attempt to enter a negative value for the amount to refund and note with the patch applied you face a validation error (without the patch, upon submission of a negative value you will be faced with a server side error) 3/ Trigger the discount modal from the borrower account page. 4/ Attempt to enter a negative value for the amount to discount and note with the patch applied you face a validation error (without the patch, upon submission of a negative value you will be faced with a server side error) 5/ Signoff Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 118428 [details] [review] Bug 27967: Add min attribute to borraccount modals This patch adds a min attribute to the form fields of the borrower account page modals to prevent negative values being entered inappropriately. Test plan 1/ Trigger the refund modal from the borrower account page. 2/ Attempt to enter a negative value for the amount to refund and note with the patch applied you face a validation error (without the patch, upon submission of a negative value you will be faced with a server side error) 3/ Trigger the discount modal from the borrower account page. 4/ Attempt to enter a negative value for the amount to discount and note with the patch applied you face a validation error (without the patch, upon submission of a negative value you will be faced with a server side error) 5/ Signoff Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for 21.05, thanks to everybody involved! Enhancement not pushed to 20.11.x |