Summary: | Multiple item URIs break redirect if TrackClicks enabled | ||
---|---|---|---|
Product: | Koha | Reporter: | Aleisha Amohia <aleisha> |
Component: | OPAC | Assignee: | Aleisha Amohia <aleisha> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | andrewfh, dcook, fridolin.somers, m.de.rooy, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.05.00,20.11.05,20.05.11
|
|
Bug Depends on: | |||
Bug Blocks: | 27961 | ||
Attachments: |
Bug 27979: Modify TrackClicks to verify URL exists in DB when multiple uri
Bug 27979: Modify TrackClicks to verify URL exists in DB when multiple uri Bug 27979: Modify TrackClicks to verify URL exists in DB when multiple uri |
Description
Aleisha Amohia
2021-03-17 20:38:01 UTC
Created attachment 118448 [details] [review] Bug 27979: Modify TrackClicks to verify URL exists in DB when multiple uri To test: 1) Go to Admin -> system preferences and enable the TrackClicks syspref (set to Track or Track anonymously) 2) Find a record in the staff client with an item. Edit the item and put two external URLs in the Uniform Resource Identifier field, e.g. "https://www.google.com/ | https://twitter.com/" 3) Search for that record in the OPAC. Notice the two links in the holdings table. 4) Click a link and confirm that you are directed to a 404. 5) Apply the patch and refresh the page 6) Click a link and confirm that you are directed to the page as expected 7) Go back to edit the record in the staff client and remove one of the links from the URI field 8) Go back to the OPAC and confirm you can still access the link as expected when there is only one URI Sponsored-by: Catalyst IT Created attachment 119088 [details] [review] Bug 27979: Modify TrackClicks to verify URL exists in DB when multiple uri To test: 1) Go to Admin -> system preferences and enable the TrackClicks syspref (set to Track or Track anonymously) 2) Find a record in the staff client with an item. Edit the item and put two external URLs in the Uniform Resource Identifier field, e.g. "https://www.google.com/ | https://twitter.com/" 3) Search for that record in the OPAC. Notice the two links in the holdings table. 4) Click a link and confirm that you are directed to a 404. 5) Apply the patch and refresh the page 6) Click a link and confirm that you are directed to the page as expected 7) Go back to edit the record in the staff client and remove one of the links from the URI field 8) Go back to the OPAC and confirm you can still access the link as expected when there is only one URI Sponsored-by: Catalyst IT Signed-off-by: David Nind <david@davidnind.com> QAing Created attachment 119693 [details] [review] Bug 27979: Modify TrackClicks to verify URL exists in DB when multiple uri To test: 1) Go to Admin -> system preferences and enable the TrackClicks syspref (set to Track or Track anonymously) 2) Find a record in the staff client with an item. Edit the item and put two external URLs in the Uniform Resource Identifier field, e.g. "https://www.google.com/ | https://twitter.com/" 3) Search for that record in the OPAC. Notice the two links in the holdings table. 4) Click a link and confirm that you are directed to a 404. 5) Apply the patch and refresh the page 6) Click a link and confirm that you are directed to the page as expected 7) Go back to edit the record in the staff client and remove one of the links from the URI field 8) Go back to the OPAC and confirm you can still access the link as expected when there is only one URI Sponsored-by: Catalyst IT Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.05 Pushed to 20.05.x for 20.05.11 Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. |