|
Description
Owen Leonard
2021-03-18 10:47:58 UTC
(In reply to Owen Leonard from comment #0) > intranet-tmpl/prog/en/modules/cataloguing/additem.tt Interloper. Created attachment 118459 [details] [review] Bug 27980: Replace obsolete title-string sorting: Catalog templates This patch modifies several catalog templates to replace the use of the "title-string" DataTables sorting method with the newer "data-order" attribute. To test, apply the patch and view the following pages to confirm that columns containing dates sort correctly when using any setting of the "dateformat" system preference: - Catalog -> Search -> Bibliographic detail page - Catalog -> Search -> Bibliograhpic detail page -> Checkout history - Search history - Current and previous catalog search sessions - Current and previous authority search sessions Created attachment 118497 [details] [review] Bug 27980: Replace obsolete title-string sorting: Catalog templates This patch modifies several catalog templates to replace the use of the "title-string" DataTables sorting method with the newer "data-order" attribute. To test, apply the patch and view the following pages to confirm that columns containing dates sort correctly when using any setting of the "dateformat" system preference: - Catalog -> Search -> Bibliographic detail page - Catalog -> Search -> Bibliograhpic detail page -> Checkout history - Search history - Current and previous catalog search sessions - Current and previous authority search sessions Created attachment 118581 [details] [review] Bug 27980: Replace obsolete title-string sorting: Catalog templates This patch modifies several catalog templates to replace the use of the "title-string" DataTables sorting method with the newer "data-order" attribute. To test, apply the patch and view the following pages to confirm that columns containing dates sort correctly when using any setting of the "dateformat" system preference: - Catalog -> Search -> Bibliographic detail page - Catalog -> Search -> Bibliograhpic detail page -> Checkout history - Search history - Current and previous catalog search sessions - Current and previous authority search sessions Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Passed QA Created attachment 118799 [details] [review] Bug 27980: (follow-up) Address missing instance - Search history -> Current and previous catalog searches Created attachment 118851 [details] [review] Bug 27980: Replace obsolete title-string sorting: Catalog templates This patch modifies several catalog templates to replace the use of the "title-string" DataTables sorting method with the newer "data-order" attribute. To test, apply the patch and view the following pages to confirm that columns containing dates sort correctly when using any setting of the "dateformat" system preference: - Catalog -> Search -> Bibliographic detail page - Catalog -> Search -> Bibliograhpic detail page -> Checkout history - Search history - Current and previous catalog search sessions - Current and previous authority search sessions Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 118852 [details] [review] Bug 27980: (follow-up) Address missing instance - Search history -> Current and previous catalog searches Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 118853 [details] [review] Bug 27980: (QA follow-up) Add missing case We missed one last case ;) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Nice one.. I spotted one last case which I've address in a QA follow-up. Passing Created attachment 119218 [details] [review] Bug 27980: Remove itemdata_publisheddate from controller This TT var was only used once, and remove in the previous patch Pushed to master for 21.05, thanks to everybody involved! Enhancement not pushed to 20.11.x |