Bug 27983

Summary: Replace obsolete title-string sorting: Acquisitions templates part 2
Product: Koha Reporter: Owen Leonard <oleonard>
Component: Staff ClientAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: amitddng135, fridolin.somers, gmcharlt, koha-bugs, kyle.m.hall, m.de.rooy, martin.renvoize, oleonard, sally.healey, testopia, tomascohen
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
21.05.00
Bug Depends on:    
Bug Blocks: 27934    
Attachments: Bug 27982: Replace obsolete title-string sorting: Acquisitions templates part 1
Bug 27983: Replace obsolete title-string sorting: Acquisitions templates part 2
Bug 27983: Replace obsolete title-string sorting: Acquisitions templates part 2
Bug 27983: Replace obsolete title-string sorting: Acquisitions templates part 2
Bug 27983: (follow-up) Address missing instances
Bug 27983: Replace obsolete title-string sorting: Acquisitions templates part 2
Bug 27983: (follow-up) Address missing instances

Description Owen Leonard 2021-03-18 13:18:14 UTC
This patch will modify the following templates to replace the old "title-string" DataTables sorting method with the built-in method using "data-order" attributes.

  intranet-tmpl/prog/en/modules/acqui/lateorders.tt
  intranet-tmpl/prog/en/modules/acqui/newordersubscription.tt
  intranet-tmpl/prog/en/modules/acqui/ordered.tt
  intranet-tmpl/prog/en/modules/acqui/orderreceive.tt
  intranet-tmpl/prog/en/modules/acqui/parcels.tt
  intranet-tmpl/prog/en/modules/acqui/spent.tt
  intranet-tmpl/prog/en/modules/acqui/supplier.tt
Comment 1 Owen Leonard 2021-03-18 15:17:39 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2021-03-18 16:49:21 UTC Comment hidden (obsolete)
Comment 3 Amit Gupta 2021-03-19 08:14:01 UTC Comment hidden (obsolete)
Comment 4 Martin Renvoize 2021-03-22 11:05:30 UTC
Created attachment 118579 [details] [review]
Bug 27983: Replace obsolete title-string sorting: Acquisitions templates part 2

This patch modifies several acquisitions templates to replace the use of
the "title-string" DataTables sorting method with the newer "data-order"
attribute.

To test, apply the patch and view the following pages to confirm that
columns containing dates sort correctly when using any setting of the
"dateformat" system preference:

- Acquisitions -> Late orders
- Acquisitions -> Vendor -> Basket -> Add to basket -> From a
  subscription
- Acquisitions -> "All available funds" table
  -> Click an "Ordered" value
  -> Click a "Spent" value
- Acquisitions -> Vendor -> Receive shipments
- Acquisitions -> Vendor
  -> test sorting of contracts in the "Contracts" table

Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize 2021-03-22 11:06:38 UTC
Excellent work, diligently worked through.

All works well, passing QA
Comment 6 Owen Leonard 2021-03-25 11:58:37 UTC
Created attachment 118782 [details] [review]
Bug 27983: (follow-up) Address missing instances

This patch cleans up some instances I missed on the first round:

- Acquisitions -> Vendor -> Receive shipments
- Acquisitions -> "All available funds" table
  -> Click an "Ordered" value
  -> Click a "Spent" value
- Acquisitions -> Vendor
 -> test sorting of contracts in the "Contracts" table
Comment 7 Martin Renvoize 2021-03-26 11:50:44 UTC
Created attachment 118848 [details] [review]
Bug 27983: Replace obsolete title-string sorting: Acquisitions templates part 2

This patch modifies several acquisitions templates to replace the use of
the "title-string" DataTables sorting method with the newer "data-order"
attribute.

To test, apply the patch and view the following pages to confirm that
columns containing dates sort correctly when using any setting of the
"dateformat" system preference:

- Acquisitions -> Late orders
- Acquisitions -> Vendor -> Basket -> Add to basket -> From a
  subscription
- Acquisitions -> "All available funds" table
  -> Click an "Ordered" value
  -> Click a "Spent" value
- Acquisitions -> Vendor -> Receive shipments
- Acquisitions -> Vendor
  -> test sorting of contracts in the "Contracts" table

Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 8 Martin Renvoize 2021-03-26 11:50:48 UTC
Created attachment 118849 [details] [review]
Bug 27983: (follow-up) Address missing instances

This patch cleans up some instances I missed on the first round:

- Acquisitions -> Vendor -> Receive shipments
- Acquisitions -> "All available funds" table
  -> Click an "Ordered" value
  -> Click a "Spent" value
- Acquisitions -> Vendor
 -> test sorting of contracts in the "Contracts" table

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 9 Martin Renvoize 2021-03-26 11:52:12 UTC
Applied 27982 and 27983 together.  Grepped for title-string in the acqui dir and in js includes.

No further cases found.. well caught on the extra's Owen.

Passing QA
Comment 10 Jonathan Druart 2021-04-06 13:58:37 UTC
Pushed to master for 21.05, thanks to everybody involved!
Comment 11 Fridolin Somers 2021-04-19 09:27:56 UTC
Enhancement not pushed to 20.11.x