| Summary: | Koha::Item::Transfer->in_transit should not count cancelled transfers | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
| Component: | Circulation | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
| Status: | CLOSED FIXED | QA Contact: | Joonas Kylmälä <joonas.kylmala> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, jonathan.druart, joonas.kylmala, kyle.m.hall, stalkernoid, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.05.00
|
|
| Circulation function: | |||
| Bug Depends on: | 26481 | ||
| Bug Blocks: | 27281 | ||
| Attachments: |
Bug 27993: Add unit tests
Bug 27993: Add handling for datecancelled in in_transit Bug 27993: Add handling for datecancelled in in_transit Bug 27993: Add unit tests Bug 27993: Add handling for datecancelled in in_transit Bug 27993: Add unit tests Bug 27993: Add handling for datecancelled in in_transit |
||
|
Description
Martin Renvoize (ashimema)
2021-03-19 08:25:20 UTC
Created attachment 118539 [details] [review] Bug 27993: Add unit tests This patch adds a unit test to check that 'in_transit' takes datecancelled into account. Created attachment 118540 [details] [review] Bug 27993: Add handling for datecancelled in in_transit This patch adds handling for the datecancelled field in the in_transit method. Test plan 1/ Run the new unit test in t/db_dependent/Koha/Item/Transfer.t Created attachment 118578 [details] [review] Bug 27993: Add handling for datecancelled in in_transit This patch adds handling for the datecancelled field in the in_transit method. Test plan 1/ Run the new unit test in t/db_dependent/Koha/Item/Transfer.t Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Created attachment 118586 [details] [review] Bug 27993: Add unit tests This patch adds a unit test to check that 'in_transit' takes datecancelled into account. Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Created attachment 118587 [details] [review] Bug 27993: Add handling for datecancelled in in_transit This patch adds handling for the datecancelled field in the in_transit method. Test plan 1/ Run the new unit test in t/db_dependent/Koha/Item/Transfer.t Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Created attachment 118588 [details] [review] Bug 27993: Add unit tests This patch adds a unit test to check that 'in_transit' takes datecancelled into account. Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Created attachment 118589 [details] [review] Bug 27993: Add handling for datecancelled in in_transit This patch adds handling for the datecancelled field in the in_transit method. Test plan 1/ Run the new unit test in t/db_dependent/Koha/Item/Transfer.t Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Pushed to master for 21.05, thanks to everybody involved! |