Summary: | Fix delete_patrons.pl if no category is passed | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Command-line Utilities | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, magnus, robin |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26517 | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.05.00
|
|
Circulation function: | |||
Bug Depends on: | 27050 | ||
Bug Blocks: | |||
Attachments: |
Bug 28001: (bug 27050 follow-up) Fix delete_patrons if no category passed
Bug 28001: (bug 27050 follow-up) Fix delete_patrons if no category passed Bug 28001: (bug 27050 follow-up) Fix delete_patrons if no category passed Bug 28001: (QA follow-up) Clarify messages and indicate test mode |
Description
Nick Clemens (kidclamp)
2021-03-19 12:37:13 UTC
Is this error triggered if you do a "dry run" (without -c|--confirm)? I have been doing some dry runs on 20.05.08 and I have not seen this error. (In reply to Magnus Enger from comment #1) > Is this error triggered if you do a "dry run" (without -c|--confirm)? I have > been doing some dry runs on 20.05.08 and I have not seen this error. I believe caused by 27050 - so not affecting 20.05 Created attachment 119363 [details] [review] Bug 28001: (bug 27050 follow-up) Fix delete_patrons if no category passed GetBorrowersToExpunge must not crash if called with an empty patron category list Test plan: Call delete_patrons.pl with and without patron categories. The script must work as expected Created attachment 119387 [details] [review] Bug 28001: (bug 27050 follow-up) Fix delete_patrons if no category passed GetBorrowersToExpunge must not crash if called with an empty patron category list Test plan: Call delete_patrons.pl with and without patron categories. The script must work as expected Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 119650 [details] [review] Bug 28001: (bug 27050 follow-up) Fix delete_patrons if no category passed GetBorrowersToExpunge must not crash if called with an empty patron category list Test plan: Call delete_patrons.pl with and without patron categories. The script must work as expected Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 119651 [details] [review] Bug 28001: (QA follow-up) Clarify messages and indicate test mode Pushed to master for 21.05, thanks to everybody involved! |