Summary: | Typo in Reply-To header | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | Notices | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | major | ||
Priority: | P5 - low | CC: | andrew, fridolin.somers, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26705 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.05.00,20.11.05
|
|
Circulation function: | |||
Bug Depends on: | 22343 | ||
Bug Blocks: | |||
Attachments: |
Bug 28023: Regression tests
Bug 28023: Fix Reply-To typo Bug 28023: Regression tests Bug 28023: Fix Reply-To typo |
Description
Tomás Cohen Arazi (tcohen)
2021-03-23 14:12:14 UTC
Created attachment 118661 [details] [review] Bug 28023: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 118662 [details] [review] Bug 28023: Fix Reply-To typo This patch fixes a typo making the header useless. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/Koha/Email.t => FAIL: The Reply-To header is not being set! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! the header is set! 5. Sign off :-D Created attachment 118666 [details] [review] Bug 28023: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 118667 [details] [review] Bug 28023: Fix Reply-To typo This patch fixes a typo making the header useless. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/Koha/Email.t => FAIL: The Reply-To header is not being set! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! the header is set! 5. Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Trivial fix, going straight for QA on this one. Works as expected, obvious oversight in original implementation.. contains tests. Passing. Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.05 Doesn't apply to 20.05. Please rebase if needed |