| Summary: | Improve breadcrumbs of cataloging search page | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Cataloging | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | fridolin.somers, m.de.rooy |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.05.00
|
|
| Circulation function: | |||
| Bug Depends on: | 27846 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 28035: Improve breadcrumbs of cataloging search page
Bug 28035: Improve breadcrumbs of cataloging search page Bug 28035: Improve breadcrumbs of cataloging search page |
||
|
Description
Owen Leonard
2021-03-25 16:38:19 UTC
Created attachment 118832 [details] [review] Bug 28035: Improve breadcrumbs of cataloging search page This patch expands the logic around the cataloging search page's breadcrumbs so that more context is provided in the breadcrumbs menu. The page title should also reflect this change. Some markup in the body of the page has been updated to clarify the page structure using headings. To test, apply the patch and go to Cataloging. - The page title and breadcrumbs menu should show "Home > Cataloging" - Perform a search which will return results from the catalog, from the reservoir, or both. The page title and breadcrumbs menu should show: "Home > Cataloging > Search results." - Perform a search which will return no results. The page title and breadcrumbs should be: "Home > Cataloging > No results found." Created attachment 118872 [details] [review] Bug 28035: Improve breadcrumbs of cataloging search page This patch expands the logic around the cataloging search page's breadcrumbs so that more context is provided in the breadcrumbs menu. The page title should also reflect this change. Some markup in the body of the page has been updated to clarify the page structure using headings. To test, apply the patch and go to Cataloging. - The page title and breadcrumbs menu should show "Home > Cataloging" - Perform a search which will return results from the catalog, from the reservoir, or both. The page title and breadcrumbs menu should show: "Home > Cataloging > Search results." - Perform a search which will return no results. The page title and breadcrumbs should be: "Home > Cataloging > No results found." Signed-off-by: David Nind <david@davidnind.com> I like the change, but looking at the page I am wondering about the structure. I think this might be another case for improving our headings. No h1, one h2 for the reservoir... should we not have a "Results in catalog" one maybe too? Created attachment 118904 [details] [review] Bug 28035: Improve breadcrumbs of cataloging search page This patch expands the logic around the cataloging search page's breadcrumbs so that more context is provided in the breadcrumbs menu. The page title should also reflect this change. Some markup in the body of the page has been updated to clarify the page structure using headings. To test, apply the patch and go to Cataloging. - The page title and breadcrumbs menu should show "Home > Cataloging" - Perform a search which will return results from the catalog, from the reservoir, or both. The page title and breadcrumbs menu should show: "Home > Cataloging > Search results." - Perform a search which will return no results. The page title and breadcrumbs should be: "Home > Cataloging > No results found." Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 21.05, thanks to everybody involved! Enhancement not pushed to 20.11.x |