Summary: | Improve breadcrumbs of CSV profiles page | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Tools | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | amitddng135, david, fridolin.somers, m.de.rooy, testopia |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This patch expands the logic around the page title and breadcrumbs of the CSV profiles page. The name of the page has also been changed from "CSV export profiles" to "CSV profiles" to match links elsewhere in Koha.
Breadcrumbs now display as:
- Initial window: Tools > CSV profiles
- New CSV profile: Tools > CSV profiles > New CSV profile
- Edit an existing CSV profile: Tools > CSV profiles > Modify a CSV profile
|
Version(s) released in: |
21.05.00
|
Circulation function: | |||
Bug Depends on: | 27846 | ||
Bug Blocks: | |||
Attachments: |
Bug 28037: Improve breadcrumbs of CSV profiles page
Bug 28037: Improve breadcrumbs of CSV profiles page Bug 28037: Improve breadcrumbs of CSV profiles page |
Description
Owen Leonard
2021-03-25 18:20:07 UTC
Created attachment 118836 [details] [review] Bug 28037: Improve breadcrumbs of CSV profiles page This patch expands the logic around the page title and breadcrumbs of the CSV profiles page. The name of the page has also been changed from "CSV export profiles" to "CSV profiles" to match links elsewhere in Koha. To test, apply the patch and go to Tools -> CSV profiles. - The initial state of the page title and breadcrumbs menu should be "Tools > CSV profiles." - Click "New CSV profile." The page title and breadcrumbs should show "Tools > CSV profiles > New CSV profile." - Edit an existing CSV profile. The page title and breadcrumbs should show "Tools > CSV profiles > Modify a CSV profile." Bug 28037: Improve breadcrumbs of CSV profiles page This patch expands the logic around the page title and breadcrumbs of the CSV profiles page. The name of the page has also been changed from "CSV export profiles" to "CSV profiles" to match links elsewhere in Koha. To test, apply the patch and go to Tools -> CSV profiles. - The initial state of the page title and breadcrumbs menu should be "Tools > CSV profiles." - Click "New CSV profile." The page title and breadcrumbs should show "Tools > CSV profiles > New CSV profile." - Edit an existing CSV profile. The page title and breadcrumbs should show "Tools > CSV profiles > Modify a CSV profile." -------------------------- Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all: a Applying: Bug 28037: Improve breadcrumbs of CSV profiles page fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/tools/csv-profiles.tt). error: could not build fake ancestor Patch failed at 0001 Bug 28037: Improve breadcrumbs of CSV profiles page The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". --------- Patch not applied. (In reply to Amit Gupta from comment #2) > Patch not applied. Did you apply all the dependencies? You have to have Bug 27846. Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all: a Applying: Bug 28037: Improve breadcrumbs of CSV profiles page fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/tools/csv-profiles.tt). error: could not build fake ancestor Patch failed at 0001 Bug 28037: Improve breadcrumbs of CSV profiles page The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". ------------------------------------------------------------------------ Patch not applied Created attachment 118948 [details] [review] Bug 28037: Improve breadcrumbs of CSV profiles page This patch expands the logic around the page title and breadcrumbs of the CSV profiles page. The name of the page has also been changed from "CSV export profiles" to "CSV profiles" to match links elsewhere in Koha. To test, apply the patch and go to Tools -> CSV profiles. - The initial state of the page title and breadcrumbs menu should be "Tools > CSV profiles." - Click "New CSV profile." The page title and breadcrumbs should show "Tools > CSV profiles > New CSV profile." - Edit an existing CSV profile. The page title and breadcrumbs should show "Tools > CSV profiles > Modify a CSV profile." Signed-off-by: David Nind <david@davidnind.com> Testing notes: - The patch and dependency (27846) applied fine for me. - Need to update the CSS for the staff interface (see https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). This makes me wonder a few things: - Should we be using Edit or Modify? Do we have a preferred term or does it not matter? - It now reads: "Modify a CSV profile" Looking at other pages, should this just be "Modify CSV profile"? (see news) - Or should we even try to include the name of the profile we also do sometimes? "Edit CSV profile '...' (see itemtypes) Still going to pass QA as this is definitely a step in the right direction and an improvement. Created attachment 119158 [details] [review] Bug 28037: Improve breadcrumbs of CSV profiles page This patch expands the logic around the page title and breadcrumbs of the CSV profiles page. The name of the page has also been changed from "CSV export profiles" to "CSV profiles" to match links elsewhere in Koha. To test, apply the patch and go to Tools -> CSV profiles. - The initial state of the page title and breadcrumbs menu should be "Tools > CSV profiles." - Click "New CSV profile." The page title and breadcrumbs should show "Tools > CSV profiles > New CSV profile." - Edit an existing CSV profile. The page title and breadcrumbs should show "Tools > CSV profiles > Modify a CSV profile." Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 21.05, thanks to everybody involved! Enhancement not pushed to 20.11.x (In reply to Katrin Fischer from comment #8) > This makes me wonder a few things: > > - Should we be using Edit or Modify? Do we have a preferred term or does it > not matter? > > - It now reads: "Modify a CSV profile" Looking at other pages, should this > just be "Modify CSV profile"? (see news) > > - Or should we even try to include the name of the profile we also do > sometimes? "Edit CSV profile '...' (see itemtypes) > > Still going to pass QA as this is definitely a step in the right direction > and an improvement. I have added Bug 28184 for this. |