| Summary: | Add Koha::Exceptions::Patron::MissingMandatoryExtendedAttribute | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Component: | Architecture, internals, and plumbing | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | david, fridolin.somers, martin.renvoize, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This patch adds a new exception for more fine-grained control on the errors when dealing with patrons and their extended attributes.
|
Version(s) released in: |
21.05.00
|
| Circulation function: | |||
| Bug Depends on: | 27858 | ||
| Bug Blocks: | 27857 | ||
| Attachments: |
Bug 28056: Unit tests
Bug 28056: Add Koha::Exceptions::Patron::MissingMandatoryExtendedAttribute Bug 28056: Unit tests Bug 28056: Add Koha::Exceptions::Patron::MissingMandatoryExtendedAttribute Bug 28056: Unit tests Bug 28056: Add Koha::Exceptions::Patron::MissingMandatoryExtendedAttribute |
||
|
Description
Tomás Cohen Arazi (tcohen)
2021-03-30 13:50:12 UTC
Created attachment 119007 [details] [review] Bug 28056: Unit tests Created attachment 119008 [details] [review] Bug 28056: Add Koha::Exceptions::Patron::MissingMandatoryExtendedAttribute This trivial patch adds a new exception for more fine-grained control on the errors when dealing with patrons and their extended attributes. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/Koha/Exceptions.t => SUCCESS: Tests pass! 3. Sign off :-D Patch doesn't apply 8-(... Applying: Bug 28056: Unit tests error: sha1 information is lacking or useless (t/Koha/Exceptions.t). error: could not build fake ancestor Patch failed at 0001 Bug 28056: Unit tests (In reply to David Nind from comment #3) > Patch doesn't apply 8-(... > > Applying: Bug 28056: Unit tests > error: sha1 information is lacking or useless (t/Koha/Exceptions.t). > error: could not build fake ancestor > Patch failed at 0001 Bug 28056: Unit tests Yeah, the dependencies were messed up. Sorry for that! Created attachment 119051 [details] [review] Bug 28056: Unit tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 119052 [details] [review] Bug 28056: Add Koha::Exceptions::Patron::MissingMandatoryExtendedAttribute This trivial patch adds a new exception for more fine-grained control on the errors when dealing with patrons and their extended attributes. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/Koha/Exceptions.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> All works as expected, thanks Tomas Created attachment 119072 [details] [review] Bug 28056: Unit tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 119073 [details] [review] Bug 28056: Add Koha::Exceptions::Patron::MissingMandatoryExtendedAttribute This trivial patch adds a new exception for more fine-grained control on the errors when dealing with patrons and their extended attributes. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/Koha/Exceptions.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 21.05, thanks to everybody involved! Enhancement not pushed to 20.11.x |