Summary: | Can't sort lists on staff client | ||
---|---|---|---|
Product: | Koha | Reporter: | Séverine Queune <severine.queune> |
Component: | Lists | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Kyle M Hall (khall) <kyle> |
Severity: | normal | ||
Priority: | P5 - low | CC: | andrew, esther.melander, fridolin.somers, george, kyle, m.de.rooy, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
21.05.00,20.11.05,20.05.11
|
Circulation function: | |
Bug Depends on: | 27715 | ||
Bug Blocks: | 28105 | ||
Attachments: |
Bug 28069: (bug 27715 follow-up) Fix sort for lists
Bug 28069: (bug 27715 follow-up) Fix sort for lists Bug 28069: (bug 27715 follow-up) Fix sort for lists |
Description
Séverine Queune
2021-04-01 13:43:32 UTC
In my test it's not possible to sort by ANY column! git bisect blames Bug 27715 - Possibly SQL injection in virtualshelves Created attachment 119226 [details] [review] Bug 28069: (bug 27715 follow-up) Fix sort for lists Sort functionality has been broken by bug 27715. We need to specify the table.column in the datatable init Note that "count" needs to be handled separately (which is a bit dirty but cannot find something better) Test plan: Create some lists, add contents, change owner and dates Sort using the different attributes and confirm that it's now working Is the "Owner" sort using the borrowernumber instead of borrower's name the excepted behaviour ? Is the "Owner" sort using the borrowernumber instead of borrower's name the excepted behaviour ? Absolutely not. However it seems that it was the behaviour pre bug 27715, so it should be addressed on its own bug report. Created attachment 119262 [details] [review] Bug 28069: (bug 27715 follow-up) Fix sort for lists Sort functionality has been broken by bug 27715. We need to specify the table.column in the datatable init Note that "count" needs to be handled separately (which is a bit dirty but cannot find something better) Test plan: Create some lists, add contents, change owner and dates Sort using the different attributes and confirm that it's now working Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> (In reply to Jonathan Druart from comment #6) > Absolutely not. However it seems that it was the behaviour pre bug 27715, so > it should be addressed on its own bug report. Thank you Jonathan ! I opened bug 28105 to fix that issue. Created attachment 119743 [details] [review] Bug 28069: (bug 27715 follow-up) Fix sort for lists Sort functionality has been broken by bug 27715. We need to specify the table.column in the datatable init Note that "count" needs to be handled separately (which is a bit dirty but cannot find something better) Test plan: Create some lists, add contents, change owner and dates Sort using the different attributes and confirm that it's now working Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.05 Pushed to 20.05.x for 20.05.11 Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. *** Bug 29045 has been marked as a duplicate of this bug. *** |