| Summary: | Some search problems | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Henri-Damien LAURENT <henridamien> |
| Component: | Searching | Assignee: | Henri-Damien LAURENT <henridamien> |
| Status: | CLOSED INVALID | QA Contact: | Bugs List <koha-bugs> |
| Severity: | normal | ||
| Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, jonathan.druart, m.de.rooy, paul.poulain, stephane.delaune |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
This patch fixes that bug.
Bug 2809 : Rebased and Reformatted for master, please test thoroughly |
||
|
Description
Chris Cormack
2010-05-21 00:56:40 UTC
This patch doesnt look like it was ever pushed ../rma/signoff/bug2809.patch:55: trailing whitespace. } error: patch failed: C4/Search.pm:950 error: C4/Search.pm: patch does not apply Changing patch status. Created attachment 4580 [details] [review] Bug 2809 : Rebased and Reformatted for master, please test thoroughly New patch created for master, no guarantee it works "no guarantee it works" => back to needs signoff "indexes_set was set on yr and date searches."
lines 'indexes_set++' are commented, then this unless condition
unless ( $indexes_set || !$index || $index =~ /(st-|phr|ext|wrdl|nb|ns)/ ) {
$struct_attr = ",wrdl";
}
become useless, right ?
Please provide a test plan for this - I have no idea what it is supposed to fix or do. GBSD: I am checking this one now.. GBSD#4 comments including some QA:
First, this patch does not have a test plan; it is very hard to know if it actually makes a difference in current Koha.
Second, the patch comments the indexes_set++ for indexes yr and acqdate; this should not be done! It actually make some searches resultless.
Test something like: yourserver/cgi-bin/koha/opac-search.pl?idx=yr&q=2005
Without the patch, it could have results.
Note however that this URL is not constructed as such by advanced search: advanced search adds a yr-limit string.
Third, the test "if ($this_limit){" should be extended to not only test for empty string but also spaces. If an empty &limit= should be appended after a search URL, it does not even hit that test.
If I append &limit=%20, it makes the search crash. This test could eliminate that (rather fictitious) situation.
My preliminary conclusion: this patch is actually not needed anymore in current Koha and in its current condition it fails QA. I would suggest to close this report. If I overlook something, please provide examples for current master to demonstrate it.
* very old entry * no test plan * no one understand what it was supposed to fix => closing |