Summary: | Add meta tag with Koha version number to staff interface pages | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | Staff interface | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | CLOSED FIXED | QA Contact: | Kyle M Hall (khall) <kyle> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, kyle, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.05.00,20.11.07
|
|
Circulation function: | |||
Attachments: |
Bug 28091: add meta content with Koha version to staff client pages
Bug 28091: add meta content with Koha version to staff client pages Bug 28091: add meta content with Koha version to staff client pages Bug 28091: Only show for logged in users |
Description
Lucas Gass (lukeg)
2021-04-05 17:57:24 UTC
Created attachment 119187 [details] [review] Bug 28091: add meta content with Koha version to staff client pages TO test: -apply patch -go to the Koha staff client and inspect the page, look at the HTML <head> -there should be a line that looks like this: <meta name="generator" content="Koha 20.12.00"> Created attachment 119188 [details] [review] Bug 28091: add meta content with Koha version to staff client pages TO test: -apply patch -go to the Koha staff client and inspect the page, look at the HTML <head> -there should be a line that looks like this: <meta name="generator" content="Koha 20.12.00"> Signed-off-by: David Nind <david@davidnind.com> I like this idea a lot, but I think it should be hidden on the login screen since that would allow an unauthenticated user to know what version of Koha is being run. That data could be used for automated attacks against Koha server. It's unlikely I know, but it is a security best practice. (In reply to Kyle M Hall from comment #3) > I like this idea a lot, but I think it should be hidden on the login screen > since that would allow an unauthenticated user to know what version of Koha > is being run. That data could be used for automated attacks against Koha > server. It's unlikely I know, but it is a security best practice. I think wrapping that in [% IF logged_in_user %] [% END %] would be sufficient to fix the issue. Created attachment 120710 [details] [review] Bug 28091: add meta content with Koha version to staff client pages TO test: -apply patch -go to the Koha staff client and inspect the page, look at the HTML <head> -there should be a line that looks like this: <meta name="generator" content="Koha 20.12.00"> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 120711 [details] [review] Bug 28091: Only show for logged in users Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 21.05, thanks to everybody involved! Small useful enhancement, I choose to backport. Pushed to 20.11.x for 20.11.07 Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. |