Summary: | Fix bad encoding of OVERRIDE_SYSPREF_LibraryName | ||
---|---|---|---|
Product: | Koha | Reporter: | Magnus Enger <magnus> |
Component: | OPAC | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | andrew, fridolin.somers, jonathan.druart, julian.maurice, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
21.05.00,20.11.05,20.05.11
|
Circulation function: | |
Attachments: |
Bug 28094: Deal with encoding for overriden sysprefs
Bug 28094: Deal with encoding for overriden sysprefs Bug 28094: Deal with encoding for overriden sysprefs |
Description
Magnus Enger
2021-04-06 11:47:55 UTC
Created attachment 119221 [details] [review] Bug 28094: Deal with encoding for overriden sysprefs The string we retrieved is UTF-8 encoded, to prevent encoding issue we must decode it first. Test plan: Easily testable with LibraryName: 1. edit /etc/apache2/sites-available/kohadev.conf 2. Add RequestHeader add X-Koha-SetEnv "OVERRIDE_SYSPREF_LibraryName Library of ❤️" 3. restart_all 4. Hit the mainpage and look at the source (or title) and confirm that the string is displayed correcty Created attachment 119245 [details] [review] Bug 28094: Deal with encoding for overriden sysprefs The string we retrieved is UTF-8 encoded, to prevent encoding issue we must decode it first. Test plan: Easily testable with LibraryName: 1. edit /etc/apache2/sites-available/kohadev.conf 2. Add RequestHeader add X-Koha-SetEnv "OVERRIDE_SYSPREF_LibraryName Library of ❤️" 3. restart_all 4. Hit the mainpage and look at the source (or title) and confirm that the string is displayed correcty Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 119369 [details] [review] Bug 28094: Deal with encoding for overriden sysprefs The string we retrieved is UTF-8 encoded, to prevent encoding issue we must decode it first. Test plan: Easily testable with LibraryName: 1. edit /etc/apache2/sites-available/kohadev.conf 2. Add RequestHeader add X-Koha-SetEnv "OVERRIDE_SYSPREF_LibraryName Library of ❤️" 3. restart_all 4. Hit the mainpage and look at the source (or title) and confirm that the string is displayed correcty Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Pushed to master for 21.05, thanks to everybody involved! Wow, thanks for fixing this so quickley! Pushed to 20.11.x for 20.11.05 Pushed to 20.05.x for 20.05.11 Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. |