Bug 28096

Summary: API datatables wrapper does not deal correctly with hidden columns
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: fridolin.somers, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
21.05.00
Bug Depends on: 25287    
Bug Blocks: 27465    
Attachments: Bug 28096: Fix table settings for API datatables wrapper
Bug 28096: Fix table settings for API datatables wrapper
Bug 28096: Fix table settings for API datatables wrapper

Description Jonathan Druart 2021-04-06 15:56:04 UTC
Bug 25287 added the table settings to the API datatables wrapper but it does not handled correctly the hidden columns
Comment 1 Jonathan Druart 2021-04-06 15:59:01 UTC
Created attachment 119232 [details] [review]
Bug 28096: Fix table settings for API datatables wrapper

Bug 25287 added the table settings to the API datatables wrapper but it does not
handled correctly the hidden columns.

Test plan:
Go to Home > Administration > Table settings
Administration > libraries
Tick "Is hidden by default" for "library_address"
Go to Home > Administration > Libraries
Click Columns and check the "Address" column, it must be hidden
Comment 2 Lucas Gass 2021-04-06 16:19:22 UTC
Created attachment 119237 [details] [review]
Bug 28096: Fix table settings for API datatables wrapper

Bug 25287 added the table settings to the API datatables wrapper but it does not
handled correctly the hidden columns.

Test plan:
Go to Home > Administration > Table settings
Administration > libraries
Tick "Is hidden by default" for "library_address"
Go to Home > Administration > Libraries
Click Columns and check the "Address" column, it must be hidden

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Katrin Fischer 2021-04-17 18:52:22 UTC
Created attachment 119800 [details] [review]
Bug 28096: Fix table settings for API datatables wrapper

Bug 25287 added the table settings to the API datatables wrapper but it does not
handled correctly the hidden columns.

Test plan:
Go to Home > Administration > Table settings
Administration > libraries
Tick "Is hidden by default" for "library_address"
Go to Home > Administration > Libraries
Click Columns and check the "Address" column, it must be hidden

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Jonathan Druart 2021-04-21 08:47:13 UTC
Pushed to master for 21.05, thanks to everybody involved!
Comment 5 Fridolin Somers 2021-04-29 11:43:04 UTC
Does not apply on 20.11.x.

I think it depends on Bug 27402, not in 20.11.x.
Correct ?