| Summary: | Use full description in layout type selection | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Label/patron card printing | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | david, fridolin.somers, jonathan.druart |
| Version: | Main | Keywords: | Manual |
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This enhancement changes the display of the drop down list when adding and editing label layouts (Tools > Label creator > Layouts) so that a full description of label types is shown instead of brief names. For example: "Only the barcode is printed" instead of "BAR".
|
Version(s) released in: |
21.05.00
|
| Circulation function: | |||
| Attachments: |
Bug 28119: Use full description in layout type selection
Bug 28119: Use full description in layout type selection Bug 28119: (follow-up) Remove unnecessary punctuation Bug 28119: Use full description in layout type selection Bug 28119: (follow-up) Remove unnecessary punctuation Bug 28119: Use full description in layout type selection |
||
|
Description
Owen Leonard
2021-04-09 12:02:05 UTC
Created attachment 119372 [details] [review] Bug 28119: Use full description in layout type selection This patch changes the template for editing label layout so that a full description of label types is shown to the user rather than brief names. To test, apply the patch and go to Tools -> Label creator -> New -> Layout. - On the "Choose layout type" line you should see selections with full descriptions, e.g. "Only the barcode is printed." - Choose a layout type and save the layout. Confirm that your choice was saved correctly. Created attachment 119439 [details] [review] Bug 28119: Use full description in layout type selection This patch changes the template for editing label layout so that a full description of label types is shown to the user rather than brief names. To test, apply the patch and go to Tools -> Label creator -> New -> Layout. - On the "Choose layout type" line you should see selections with full descriptions, e.g. "Only the barcode is printed." - Choose a layout type and save the layout. Confirm that your choice was saved correctly. Signed-off-by: David Nind <david@davidnind.com> I agree that having more meaningful descriptions here is much more useful than just the code. Only a really very trivial comment - should the options have a full stop at the end of the sentence? The option descriptions are full sentences and it would normally makes sense to have a full stop. However, it looks a little out of place with all the other drop down lists that don't. Either way, it is a nice improvement over the way it is now. I was going to tell the same as David about the full stop. Owen what do you think? Created attachment 119558 [details] [review] Bug 28119: (follow-up) Remove unnecessary punctuation Should it be proceeds or not maybe preceeds? Created attachment 119810 [details] [review] Bug 28119: Use full description in layout type selection This patch changes the template for editing label layout so that a full description of label types is shown to the user rather than brief names. To test, apply the patch and go to Tools -> Label creator -> New -> Layout. - On the "Choose layout type" line you should see selections with full descriptions, e.g. "Only the barcode is printed." - Choose a layout type and save the layout. Confirm that your choice was saved correctly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 119811 [details] [review] Bug 28119: (follow-up) Remove unnecessary punctuation Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 119947 [details] [review] Bug 28119: Use full description in layout type selection This patch changes the template for editing label layout so that a full description of label types is shown to the user rather than brief names. To test, apply the patch and go to Tools -> Label creator -> New -> Layout. - On the "Choose layout type" line you should see selections with full descriptions, e.g. "Only the barcode is printed." - Choose a layout type and save the layout. Confirm that your choice was saved correctly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Bug 28119: (follow-up) Remove unnecessary punctuation Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 21.05, thanks to everybody involved! (In reply to Katrin Fischer from comment #6) > Should it be proceeds or not maybe preceeds? Nice catch Katrin! It should be "preceeds".. "before" is also an alternative. Enhancement not pushed to 20.11.x |