Description
Katrin Fischer
2021-04-12 09:14:31 UTC
Just came up again as a question in training - would still be a nice addition :) Created attachment 151550 [details] [review] Bug 28130: [WIP] Manage a patron's subscription alerts Patch in progress Created attachment 151619 [details] [review] Bug 28130: Manage a patron's subscription alerts This enhancement adds an 'Alert subscriptions' page to a patron account to easily view or cancel email alerts the patron has subscribed to. To test: 1. Go to Cataloging. Create a biblio. 2. Go to Tools -> Notices & slips. Create a notice under the "Serials (new issue)" module, if you don't already have one. 3. Go to Serials. Create a subscription. Link the biblio you just created. Add info like the callnumber, location, library. Choose your notice under Patron notification. Fill out the remaining details and save your subscription. 4. Open this record in the OPAC. Under the Subscriptions tab, click the button to "Subscribe to email notification on new issues" 5. Go back to the staff interface. Go to your patron account. 6. Notice there is a new "Alert subscriptions" tab in the left sidebar menu. The number in brackets should say 1, for the subscription you just enabled email alerts. 7. Click into the page. Confirm your subscription shows in the table. 8. Click the button to unsubscribe. A confirmation should pop up. Confirm you can cancel the unsubscribe action. Then confirm you can unsubscribe using this button. 9. Confirm tests pass t/db_dependent/Koha/Patron.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Wuerttemberg An error occurs when trying to open a sandbox with the enhancement. Part of the error trace says: "Error trace Could not mkdir /tmp/cgi_compile_22068: No space left on device at /usr/share/perl5/CGI/Compile.pm line 195 1. in CGI::Compile::_eval at /usr/share/perl5/CGI/Compile.pm line 195 2. 192: $tmp_dir ||= File::Spec->catfile(File::Spec->tmpdir, "cgi_compile_$$"); 3. 193: 4. 194: if (! -d $tmp_dir) { 5. 195: mkdir $tmp_dir or die "Could not mkdir $tmp_dir: $!"; 6. 196: chmod 0700, $tmp_dir or die "Could not chmod 0700 $tmp_dir: $!"; 7. 197: } 8. 198: " I could send the complete error trace if needed. I'm sorry that was a sandbox issue. The enhancement works fine. But it's for the staff client. First of all, we would like to have it for the patron itself, in hers or his account in the opac. Besides that, it looks fine to me. Created attachment 151656 [details] [review] Bug 28130: Manage a patron's subscription alerts This enhancement adds an 'Alert subscriptions' page to a patron account to easily view or cancel email alerts the patron has subscribed to. To test: 1. Go to Cataloging. Create a biblio. 2. Go to Tools -> Notices & slips. Create a notice under the "Serials (new issue)" module, if you don't already have one. 3. Go to Serials. Create a subscription. Link the biblio you just created. Add info like the callnumber, location, library. Choose your notice under Patron notification. Fill out the remaining details and save your subscription. 4. Open this record in the OPAC. Under the Subscriptions tab, click the button to "Subscribe to email notification on new issues" 5. Go back to the staff interface. Go to your patron account. 6. Notice there is a new "Alert subscriptions" tab in the left sidebar menu. The number in brackets should say 1, for the subscription you just enabled email alerts. 7. Click into the page. Confirm your subscription shows in the table. 8. Click the button to unsubscribe. A confirmation should pop up. Confirm you can cancel the unsubscribe action. Then confirm you can unsubscribe using this button. 9. Confirm tests pass t/db_dependent/Koha/Patron.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Wuerttemberg Created attachment 151657 [details] [review] Bug 28130: Manage subscription alerts on OPAC This patch adds an 'Alert subscriptions' tab to the patron's account on the OPAC, so they can easily view or cancel email alerts they have subscribed to. To test: 1. Subscribe to email alerts for one or more subscriptions via the OPAC 2. Go to your account, notice the new 'Alert subscriptions' menu option, click here 3. Confirm your subscribed alerts show here. Confirm the table sorting works etc (JS enabled). 4. Test unsubscribing from email alerts, make sure the confirmation pop-up works as expected (JS enabled). 5. Confirm that, when unsubscribing, you are redirected back to this page. 6. Confirm the menu option disappears from the left sidebar navigation if you have no alert subscriptions. Sponsored-by: Bibliotheksservice-Zentrum Baden-Wuerttemberg Created attachment 151658 [details] [review] Bug 28130: Manage a patron's subscription alerts This enhancement adds an 'Alert subscriptions' page to a patron account to easily view or cancel email alerts the patron has subscribed to. To test: 1. Go to Cataloging. Create a biblio. 2. Go to Tools -> Notices & slips. Create a notice under the "Serials (new issue)" module, if you don't already have one. 3. Go to Serials. Create a subscription. Link the biblio you just created. Add info like the callnumber, location, library. Choose your notice under Patron notification. Fill out the remaining details and save your subscription. 4. Open this record in the OPAC. Under the Subscriptions tab, click the button to "Subscribe to email notification on new issues" 5. Go back to the staff interface. Go to your patron account. 6. Notice there is a new "Alert subscriptions" tab in the left sidebar menu. The number in brackets should say 1, for the subscription you just enabled email alerts. 7. Click into the page. Confirm your subscription shows in the table. 8. Click the button to unsubscribe. A confirmation should pop up. Confirm you can cancel the unsubscribe action. Then confirm you can unsubscribe using this button. 9. Confirm tests pass t/db_dependent/Koha/Patron.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Wuerttemberg Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller@bsz-bw.de> Created attachment 151659 [details] [review] Bug 28130: Manage subscription alerts on OPAC This patch adds an 'Alert subscriptions' tab to the patron's account on the OPAC, so they can easily view or cancel email alerts they have subscribed to. To test: 1. Subscribe to email alerts for one or more subscriptions via the OPAC 2. Go to your account, notice the new 'Alert subscriptions' menu option, click here 3. Confirm your subscribed alerts show here. Confirm the table sorting works etc (JS enabled). 4. Test unsubscribing from email alerts, make sure the confirmation pop-up works as expected (JS enabled). 5. Confirm that, when unsubscribing, you are redirected back to this page. 6. Confirm the menu option disappears from the left sidebar navigation if you have no alert subscriptions. Sponsored-by: Bibliotheksservice-Zentrum Baden-Wuerttemberg Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller@bsz-bw.de> Tested with alerts for two different subscriptions, looks good to me. Maybe someone else can have a look at it too to verify. I'm not sure why this was set to Patch doesn't apply, it applies cleanly on main for me. Created attachment 151814 [details] [review] Bug 28130: Manage a patron's subscription alerts This enhancement adds an 'Alert subscriptions' page to a patron account to easily view or cancel email alerts the patron has subscribed to. To test: 1. Go to Cataloging. Create a biblio. 2. Go to Tools -> Notices & slips. Create a notice under the "Serials (new issue)" module, if you don't already have one. 3. Go to Serials. Create a subscription. Link the biblio you just created. Add info like the callnumber, location, library. Choose your notice under Patron notification. Fill out the remaining details and save your subscription. 4. Open this record in the OPAC. Under the Subscriptions tab, click the button to "Subscribe to email notification on new issues" 5. Go back to the staff interface. Go to your patron account. 6. Notice there is a new "Alert subscriptions" tab in the left sidebar menu. The number in brackets should say 1, for the subscription you just enabled email alerts. 7. Click into the page. Confirm your subscription shows in the table. 8. Click the button to unsubscribe. A confirmation should pop up. Confirm you can cancel the unsubscribe action. Then confirm you can unsubscribe using this button. 9. Confirm tests pass t/db_dependent/Koha/Patron.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Wuerttemberg Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller@bsz-bw.de> Signed-off-by: Sam Lau <samalau@gmail.com> Created attachment 151815 [details] [review] Bug 28130: Manage subscription alerts on OPAC This patch adds an 'Alert subscriptions' tab to the patron's account on the OPAC, so they can easily view or cancel email alerts they have subscribed to. To test: 1. Subscribe to email alerts for one or more subscriptions via the OPAC 2. Go to your account, notice the new 'Alert subscriptions' menu option, click here 3. Confirm your subscribed alerts show here. Confirm the table sorting works etc (JS enabled). 4. Test unsubscribing from email alerts, make sure the confirmation pop-up works as expected (JS enabled). 5. Confirm that, when unsubscribing, you are redirected back to this page. 6. Confirm the menu option disappears from the left sidebar navigation if you have no alert subscriptions. Sponsored-by: Bibliotheksservice-Zentrum Baden-Wuerttemberg Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller@bsz-bw.de> Signed-off-by: Sam Lau <samalau@gmail.com> Created attachment 153779 [details] [review] Bug 28130: Manage a patron's subscription alerts This enhancement adds an 'Alert subscriptions' page to a patron account to easily view or cancel email alerts the patron has subscribed to. To test: 1. Go to Cataloging. Create a biblio. 2. Go to Tools -> Notices & slips. Create a notice under the "Serials (new issue)" module, if you don't already have one. 3. Go to Serials. Create a subscription. Link the biblio you just created. Add info like the callnumber, location, library. Choose your notice under Patron notification. Fill out the remaining details and save your subscription. 4. Open this record in the OPAC. Under the Subscriptions tab, click the button to "Subscribe to email notification on new issues" 5. Go back to the staff interface. Go to your patron account. 6. Notice there is a new "Alert subscriptions" tab in the left sidebar menu. The number in brackets should say 1, for the subscription you just enabled email alerts. 7. Click into the page. Confirm your subscription shows in the table. 8. Click the button to unsubscribe. A confirmation should pop up. Confirm you can cancel the unsubscribe action. Then confirm you can unsubscribe using this button. 9. Confirm tests pass t/db_dependent/Koha/Patron.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Wuerttemberg Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller@bsz-bw.de> Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 153780 [details] [review] Bug 28130: Manage subscription alerts on OPAC This patch adds an 'Alert subscriptions' tab to the patron's account on the OPAC, so they can easily view or cancel email alerts they have subscribed to. To test: 1. Subscribe to email alerts for one or more subscriptions via the OPAC 2. Go to your account, notice the new 'Alert subscriptions' menu option, click here 3. Confirm your subscribed alerts show here. Confirm the table sorting works etc (JS enabled). 4. Test unsubscribing from email alerts, make sure the confirmation pop-up works as expected (JS enabled). 5. Confirm that, when unsubscribing, you are redirected back to this page. 6. Confirm the menu option disappears from the left sidebar navigation if you have no alert subscriptions. Sponsored-by: Bibliotheksservice-Zentrum Baden-Wuerttemberg Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller@bsz-bw.de> Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 153781 [details] [review] Bug 28130: (QA follow-up) Use schema result to fetch alerts to allow for prefetch Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 153782 [details] [review] Bug 28130: (QA follow-up) Tidy Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 23.11. Nice work everyone, thanks! Enhancement not pushed to 23.05.x *** Bug 25848 has been marked as a duplicate of this bug. *** |