Summary: | Transferred holds are not triggering | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Circulation | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | andrew, fridolin.somers, gmcharlt, janet.mcgowan, jonathan.druart, joonas.kylmala, kyle.m.hall, martin.renvoize, sally.healey |
Version: | Main | Keywords: | rel_20_11_candidate |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.05.00,20.11.05
|
|
Circulation function: | |||
Bug Depends on: | 25690 | ||
Bug Blocks: | 28139 | ||
Attachments: |
Bug 28136: Handle Transferred status for ResFound
Bug 28136: Handle Transferred status for ResFound Bug 28136: Handle Transferred status for ResFound |
Description
Nick Clemens (kidclamp)
2021-04-12 14:16:57 UTC
bug 25690 added a new status for ResFound return value in CheckReserves This value is not handled in circ/returns.pl Created attachment 119456 [details] [review] Bug 28136: Handle Transferred status for ResFound bug 25690 added a new 'Transferred' status to 'ResFound', this status needs to be handled in circ/returns.pl To test: 1 - Place a hold on an item at Branch B for pickup at Branch A 2 - Check in the item at Branch B - confirm hold and transfer 3 - Check in the item at Branch A - nothing happens? 4 - Apply patch 5 - Checkin in the item at Branch A - hold popup appears 6 - Clear the hold and place it again 7 - Set system preference 'HoldsAutoFill' to do 8 - Check in the item at Branch B - hold is found and confirmed 9 - Check in the item at Branch A - hold is found and confirmed Created attachment 119508 [details] [review] Bug 28136: Handle Transferred status for ResFound bug 25690 added a new 'Transferred' status to 'ResFound', this status needs to be handled in circ/returns.pl To test: 1 - Place a hold on an item at Branch B for pickup at Branch A 2 - Check in the item at Branch B - confirm hold and transfer 3 - Check in the item at Branch A - nothing happens? 4 - Apply patch 5 - Checkin in the item at Branch A - hold popup appears 6 - Clear the hold and place it again 7 - Set system preference 'HoldsAutoFill' to do 8 - Check in the item at Branch B - hold is found and confirmed 9 - Check in the item at Branch A - hold is found and confirmed Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Thanks Nick. I noticed same bug with the Processing state, I will file separate bug for it and also refactor this code here so that similar bug will not happen in the future if C4::Reserves::CheckReserves return values change. Created attachment 119577 [details] [review] Bug 28136: Handle Transferred status for ResFound bug 25690 added a new 'Transferred' status to 'ResFound', this status needs to be handled in circ/returns.pl To test: 1 - Place a hold on an item at Branch B for pickup at Branch A 2 - Check in the item at Branch B - confirm hold and transfer 3 - Check in the item at Branch A - nothing happens? 4 - Apply patch 5 - Checkin in the item at Branch A - hold popup appears 6 - Clear the hold and place it again 7 - Set system preference 'HoldsAutoFill' to do 8 - Check in the item at Branch B - hold is found and confirmed 9 - Check in the item at Branch A - hold is found and confirmed Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> We just got bitten by this one too.. Works as expected, passes QA scripts, Passing QA. I look forward to some promised refactoring/will happily lend a hand to that refactoring effort... this code is spaghetti that we're slowly getting to unpick :) Pushed to master for 21.05, thanks to everybody involved! (In reply to Martin Renvoize from comment #6) > I look forward to some promised refactoring/will happily lend a hand to that > refactoring effort... this code is spaghetti that we're slowly getting to > unpick :) The refactoring is waiting already for sign-off in bug 28139. :) (In reply to Joonas Kylmälä from comment #8) > (In reply to Martin Renvoize from comment #6) > > I look forward to some promised refactoring/will happily lend a hand to that > > refactoring effort... this code is spaghetti that we're slowly getting to > > unpick :) > > The refactoring is waiting already for sign-off in bug 28139. :) Excellent.. that's just hit the next item in my list then :) Pushed to 20.11.x for 20.11.05 Missing dependency (bug 25690), not backported to 20.05 |