Summary: | Accessibility: OPAC - "sort_by" select isn't labelled on search results page | ||
---|---|---|---|
Product: | Koha | Reporter: | Henry Bolshaw <bolshawh> |
Component: | OPAC | Assignee: | Henry Bolshaw <bolshawh> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | andrew, fridolin.somers, martin.renvoize |
Version: | Main | Keywords: | Academy, accessibility |
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
21.05.00,20.11.06
|
Circulation function: | |
Attachments: |
Bug 28140: Accessibility: OPAC - "sort_by" select isn't labelled on search results page
Bug 28140: Accessibility: OPAC - "sort_by" select isn't labelled on search results page Bug 28140: Accessibility: OPAC - "sort_by" select isn't labelled on search results page |
Description
Henry Bolshaw
2021-04-13 10:31:10 UTC
Created attachment 119528 [details] [review] Bug 28140: Accessibility: OPAC - "sort_by" select isn't labelled on search results page This patch adds a label to the sort function on the OPAC results page to provide context to screen readers and improve accessibility. The label is visually hidden and does not change how the page displays. To test: - Search for something on the OPAC - Change how the results are sorted and confirm sort still works - Confirm that there are no visual changes to the page - Inspect the sort function to confirm it now has a label - Ideally confirm the label works with a screenreader Created attachment 119556 [details] [review] Bug 28140: Accessibility: OPAC - "sort_by" select isn't labelled on search results page This patch adds a label to the sort function on the OPAC results page to provide context to screen readers and improve accessibility. The label is visually hidden and does not change how the page displays. To test: - Search for something on the OPAC - Change how the results are sorted and confirm sort still works - Confirm that there are no visual changes to the page - Inspect the sort function to confirm it now has a label - Ideally confirm the label works with a screenreader Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 119750 [details] [review] Bug 28140: Accessibility: OPAC - "sort_by" select isn't labelled on search results page This patch adds a label to the sort function on the OPAC results page to provide context to screen readers and improve accessibility. The label is visually hidden and does not change how the page displays. To test: - Search for something on the OPAC - Change how the results are sorted and confirm sort still works - Confirm that there are no visual changes to the page - Inspect the sort function to confirm it now has a label - Ideally confirm the label works with a screenreader Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Nice one Henry! Passing QA Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.06 Doesn't apply cleanly to 20.05. Please rebase if needed. |