Bug 28143

Summary: @INC filled with duplicates of opachtdocs and intrahtdocs
Product: Koha Reporter: Julian Maurice <julian.maurice>
Component: Architecture, internals, and plumbingAssignee: Didier Gautheron <didier.gautheron>
Status: RESOLVED DUPLICATE QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: didier.gautheron, joonas.kylmala, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 28143: Copy array before modifying it for testing

Description Julian Maurice 2021-04-13 13:13:54 UTC
Steps to reproduce:
1. Have a $KOHA_CONF with at least 2 'pluginsdir' entries. You need at least one plugin with a 'tool', 'report', or 'configure' method. This will be useful to trigger the loading of Koha::Plugins::Handler. The KitchenSink module is perfect for that.
2. Start starman with only 1 worker (not necessary but it's easier to reproduce the problem that way)
3. Load staff client home page multiple times
4. Run the plugin method of your choice
5. Go to the About page, you should see the template directories in "Perl @INC"

The problem is located in C4::Templates::badtemplatecheck, which push 'opachtdocs' and 'intrahtdocs' config entries directly into the 'pluginsdir' key of global variable $context
Comment 1 Didier Gautheron 2021-04-14 09:47:37 UTC
Created attachment 119553 [details] [review]
Bug 28143: Copy array before modifying it for testing

To test:
1. Have a $KOHA_CONF with at least 2 'pluginsdir' entries. You need at least one plugin with a 'tool', 'report', or 'configure' method. This will be useful to trigger the loading of Koha::Plugins::Handler. The KitchenSink module is perfect for that.
2. Start starman with only 1 worker (not necessary but it's easier to reproduce the problem that way)
3. Load staff client home page multiple times
4. Run the plugin method of your choice
5. Go to the About page, you should see the template directories in "Perl @INC"
6. Apply patch
7. Redo 3
8. No more template directories.
Comment 2 Joonas Kylmälä 2021-11-06 16:41:34 UTC
Fixed already by bug 28303.

*** This bug has been marked as a duplicate of bug 28303 ***