| Summary: | E-mail address used on error pages should respect ReplytoDefault | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Templates | Assignee: | Marcel de Rooy <m.de.rooy> |
| Status: | Pushed to main --- | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | m.de.rooy, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
25.11.00
|
|
| Circulation function: | |||
| Attachments: |
Bug 28146: Respect ReplytoDefault in error pages
Bug 28146: Respect ReplytoDefault in error pages |
||
Please also prefer ReplyToDefault here with a fallback to KohaAdminEmailAddress. We now have:
my $admin = C4::Context->preference('KohaAdminEmailAddress');
But: In some cases this will be a noreply-address. We should be using inbound_email_address or at least prefer ReplyToDefault.
Created attachment 187463 [details] [review] Bug 28146: Respect ReplytoDefault in error pages Test plan: Fill ReplytoDefault. Check an error page on OPAC and intranet. Verify that the send mail link refers to that email address. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Trivial patch. Self signoff Created attachment 187654 [details] [review] Bug 28146: Respect ReplytoDefault in error pages Test plan: Fill ReplytoDefault. Check an error page on OPAC and intranet. Verify that the send mail link refers to that email address. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Nice work everyone! Pushed to main for 25.11 |
"admin" is sent from C4::Output::output_error, we should use Koha.Preference('KohaAdminEmailAddress') from the template instead koha-tmpl/intranet-tmpl/prog/en/includes/prefs-menu.inc: [% IF ( admin ) %] koha-tmpl/intranet-tmpl/prog/en/modules/errors/errorpage.tt: <li>To report a broken link or any other issue, please contact the Koha Administrator. <a href="mailto:[% admin | uri %]">Send email</a></li> koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/errorpage.tt: <a href="mailto:[% admin | uri %]">Send email</a>.</li> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt: <li>To report this error, you can email the Koha Administrator.<a href="mailto:[% admin | uri %]">Email</a></li> C4/Output.pm: admin => $admin, errors/400.pl: admin => $admin, errors/401.pl: admin => $admin, errors/402.pl: admin => $admin, errors/403.pl: admin => $admin, errors/404.pl: admin => $admin, errors/500.pl: admin => $admin, opac/errors/400.pl: admin => $admin, opac/errors/401.pl: admin => $admin, opac/errors/402.pl: admin => $admin, opac/errors/403.pl: admin => $admin, opac/errors/404.pl: admin => $admin, opac/errors/500.pl: admin => $admin,