Bug 28146

Summary: E-mail address used on error pages should respect ReplyToDefault
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low    
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:

Description Jonathan Druart 2021-04-14 12:29:55 UTC
"admin" is sent from C4::Output::output_error, we should use Koha.Preference('KohaAdminEmailAddress') from the template instead

koha-tmpl/intranet-tmpl/prog/en/includes/prefs-menu.inc:        [% IF ( admin ) %]

koha-tmpl/intranet-tmpl/prog/en/modules/errors/errorpage.tt:            <li>To report a broken link or any other issue, please contact the Koha Administrator. <a href="mailto:[% admin | uri %]">Send email</a></li>

koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/errorpage.tt:                                    <a href="mailto:[% admin | uri %]">Send email</a>.</li>                                                          

koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt:                            <li>To report this error, you can email the Koha Administrator.<a href="mailto:[% admin | uri %]">Email</a></li>                


C4/Output.pm:        admin => $admin,
errors/400.pl:    admin => $admin,
errors/401.pl:    admin => $admin,
errors/402.pl:    admin => $admin,
errors/403.pl:    admin => $admin,
errors/404.pl:    admin => $admin,
errors/500.pl:    admin => $admin,
opac/errors/400.pl:    admin => $admin,
opac/errors/401.pl:    admin => $admin,
opac/errors/402.pl:    admin => $admin,
opac/errors/403.pl:    admin => $admin,
opac/errors/404.pl:    admin => $admin,
opac/errors/500.pl:    admin => $admin,
Comment 1 Katrin Fischer 2021-04-17 18:15:21 UTC
Please also prefer ReplyToDefault here with a fallback to KohaAdminEmailAddress.
Comment 2 Katrin Fischer 2023-07-01 08:11:29 UTC
We now have:

my $admin = C4::Context->preference('KohaAdminEmailAddress');

But: In some cases this will be a noreply-address. We should be using inbound_email_address or at least prefer ReplyToDefault.