| Summary: | Translate script faces encoding issues | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | I18N/L10N | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | f.demians, fridolin.somers, joonas.kylmala, julian.maurice, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28281 | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.05.00
|
|
| Circulation function: | |||
| Bug Depends on: | 22824, 25067 | ||
| Bug Blocks: | 27623 | ||
| Attachments: |
Bug 28154: Fix encoding issues on Koha-pref.pot
Bug 28154: Fix encoding issues on Koha-pref.pot Bug 28154: Fix encoding issues on Koha-installer.pot Bug 28154: Fix encoding issues on Koha-pref.pot Bug 28154: Fix encoding issues on Koha-installer.pot |
||
|
Description
Jonathan Druart
2021-04-15 14:57:57 UTC
Git bisect blames commit d6d01169509999e22fbf33d839a41e402cb93a38 Bug 22824: Replace YAML::Syck with YAML::XS % file misc/translator/Koha-pref.pot misc/translator/Koha-pref.pot: GNU gettext message catalogue, Non-ISO extended-ASCII text, with very long lines Created attachment 119636 [details] [review] Bug 28154: Fix encoding issues on Koha-pref.pot Maybe this occurrence needs to be fixed as well: misc/translator/xgettext-installer:Locale::PO->save_file_fromhash($output, $pot); Cannot focus more on this one for today. Created attachment 119695 [details] [review] Bug 28154: Fix encoding issues on Koha-pref.pot Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Created attachment 119696 [details] [review] Bug 28154: Fix encoding issues on Koha-installer.pot Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> (In reply to Jonathan Druart from comment #4) > Maybe this occurrence needs to be fixed as well: > misc/translator/xgettext-installer:Locale::PO->save_file_fromhash($output, > $pot); Yep, you were right. Fixed in the 2nd patch Created attachment 119709 [details] [review] Bug 28154: Fix encoding issues on Koha-pref.pot Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 119710 [details] [review] Bug 28154: Fix encoding issues on Koha-installer.pot Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Good catch, Passing QA (In reply to Julian Maurice from comment #8) > (In reply to Jonathan Druart from comment #4) > > Maybe this occurrence needs to be fixed as well: > > misc/translator/xgettext-installer:Locale::PO->save_file_fromhash($output, > > $pot); > > Yep, you were right. Fixed in the 2nd patch Can you detail what it fixes? (In reply to Jonathan Druart from comment #12) > Can you detail what it fixes? There is no real problem right now as there is no non-ASCII character in installer files, but if you add one you will see encoding issues. For instance, add a 'é' to installer/data/mysql/en/mandatory/auth_values.yml - "Default Koha system authorised values é" and run `gulp po:update --lang pl-PL You should see misc/translator/Koha-installer.pot:972:46: Séquence d'octets multiples invalide msgmerge: 1 erreur fatale trouvée [14:55:39] Finished 'po_update_installer' after 152 ms After the patch, there should be no errors Right, thanks! I've tried yesterday with an other file and not in the description. Now I recreate it. Pushed to master for 21.05, thanks to everybody involved! Can this be pushed to 20.11.x even it does not contain Bug 22824 ? |