| Summary: | URI-encode existing values put into query string for z39.50 authority search | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Phil Ringnalda <phil> |
| Component: | MARC Authority data support | Assignee: | Phil Ringnalda <phil> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | andrew, fridolin.somers, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.05.00,20.11.06,20.05.12
|
|
| Circulation function: | |||
| Attachments: |
Bug 28159: URI-encode existing values put into query string for z39.50 authority search
Bug 28159: URI-encode existing values put into query string for z39.50 authority search Bug 28159: URI-encode existing values put into query string for z39.50 authority search |
||
|
Description
Phil Ringnalda
2021-04-16 16:33:54 UTC
Created attachment 119768 [details] [review] Bug 28159: URI-encode existing values put into query string for z39.50 authority search When you trigger a z39.50 search from an existing authority record, Koha prefills the search form with the value in the record. But because that value passes through a URL, if it isn't URI-encoded characters like & or ; will cut off the value. Test plan: 1) Authorities - New authority - Corporate Name 2) Tab 1, click "HEADING-CORPORATE NAME" to expand subfields 3) Subfield a, type foo & bar ; baz 4) Click Z39.50/SRU search 5) Ensure the whole string appears in the Author (corporate) field in the popup Created attachment 119949 [details] [review] Bug 28159: URI-encode existing values put into query string for z39.50 authority search When you trigger a z39.50 search from an existing authority record, Koha prefills the search form with the value in the record. But because that value passes through a URL, if it isn't URI-encoded characters like & or ; will cut off the value. Test plan: 1) Authorities - New authority - Corporate Name 2) Tab 1, click "HEADING-CORPORATE NAME" to expand subfields 3) Subfield a, type foo & bar ; baz 4) Click Z39.50/SRU search 5) Ensure the whole string appears in the Author (corporate) field in the popup Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 120713 [details] [review] Bug 28159: URI-encode existing values put into query string for z39.50 authority search When you trigger a z39.50 search from an existing authority record, Koha prefills the search form with the value in the record. But because that value passes through a URL, if it isn't URI-encoded characters like & or ; will cut off the value. Test plan: 1) Authorities - New authority - Corporate Name 2) Tab 1, click "HEADING-CORPORATE NAME" to expand subfields 3) Subfield a, type foo & bar ; baz 4) Click Z39.50/SRU search 5) Ensure the whole string appears in the Author (corporate) field in the popup Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.06 Pushed to 20.05.x for 20.05.12 Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. |