| Summary: | Allow Koha::Patron->extended_attributes be passed a library_id | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Component: | Architecture, internals, and plumbing | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Status: | In Discussion --- | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | ||
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
With bug 28157 I'm not going forward with this one. Not closing it, as it might be handy in a near future. Sure this can't be closed? Or moved out of "In discussion" if it would be deemed useful? |
Koha::Patron::Attributes->filter_by_branch_limitations accepts the parameter, and falls back to C4::Context->userenv->{branch} if omitted. Lacking the parameter in Koha::Patron->extended_attributes makes it always fallback to userenv, thus forcing the caller to deal with that instead of just passing the parameter. Examples: - A CLI script with a --library_id param for setting extended attributes would be forced to mock a userenv for checks to work - An API route would need to deal with that as well. A minor and harmless change adding this parameter would allow more straight-forward use of this method.