| Summary: | Sample notices SQL fails on HOLD_REMINDER: Column count doesn't match value count | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Victor Grousset/tuxayo <victor> |
| Component: | Tools | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.05.00
|
|
| Circulation function: | |||
| Bug Depends on: | 15986 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 28198: Correct sample HOLD_REMINDER notice for French
Bug 28198: Correct sample HOLD_REMINDER notice for French Bug 28198: Correct sample HOLD_REMINDER notice for it,nb,pl,ru |
||
note: workaround: remove from installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql
The line:
('reserves','HOLD_REMINDER','','Waiting hold reminder',0,'You have waiting holds.','Dear [% borrower.firstname %] [% borrower.surname %],\r\n\r\nThe following holds are waiting at [% branch.branchname %]:\r\n\\r\n[% FOREACH hold IN holds %]\r\n [% hold.biblio.title %] : waiting since [% hold.waitingdate | $KohaDates %]\r\n[% END %]','email'),
Created attachment 120183 [details] [review] Bug 28198: Correct sample HOLD_REMINDER notice for French To test: 1 - sudo koha-mysql kohadev 2 - DELETE FROM letter 3 - cat installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql | sudo koha-mysql kohadev 4 - Error! 5 - Apply patch 6 - Repeat 1-3 7 - Success! Created attachment 120187 [details] [review] Bug 28198: Correct sample HOLD_REMINDER notice for French To test: 1 - sudo koha-mysql kohadev 2 - DELETE FROM letter 3 - cat installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql | sudo koha-mysql kohadev 4 - Error! 5 - Apply patch 6 - Repeat 1-3 7 - Success! Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Created attachment 120188 [details] [review] Bug 28198: Correct sample HOLD_REMINDER notice for it,nb,pl,ru It turns out that ea6467724cf8e6fac2224e1dcb6c6ddee73736af also caused the same issue in these locales Also e0b0e908f767e510c5538d8e5cfb25f994579441 (a follow up) caused the issue in it-IT == Test plan == Paste all this :D ``` # doesn't work without this patch applied echo "DELETE FROM letter;" | sudo koha-mysql kohadev cat installer/data/mysql/nb-NO/1-Obligatorisk/sample_notices.sql | sudo koha-mysql kohadev echo "DELETE FROM letter;" | sudo koha-mysql kohadev cat installer/data/mysql/pl-PL/mandatory/sample_notices.sql | sudo koha-mysql kohadev echo "DELETE FROM letter;" | sudo koha-mysql kohadev cat installer/data/mysql/ru-RU/mandatory/sample_notices.sql | sudo koha-mysql kohadev echo "DELETE FROM letter;" | sudo koha-mysql kohadev cat installer/data/mysql/it-IT/necessari/notices.sql | sudo koha-mysql kohadev # test all the rest ## fixed by previous patch, double checking echo "DELETE FROM letter;" | sudo koha-mysql kohadev cat installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql | sudo koha-mysql kohadev ## was already working, just double checking echo "DELETE FROM letter;" | sudo koha-mysql kohadev cat installer/data/mysql/fr-CA/obligatoire/sample_notices.sql | sudo koha-mysql kohadev echo "DELETE FROM letter;" | sudo koha-mysql kohadev cat installer/data/mysql/uk-UA/mandatory/sample_notices.sql | sudo koha-mysql kohadev ``` Thanks, it works :D, fr-FR is fixed. Pushed to master for 21.05, thanks to everybody involved! |
DBD::mysql::st execute failed: Column count doesn't match value count at row 15 Row 15 is koha_1 | ('reserves','HOLD_REMINDER','','Waiting hold reminder',0,'You have waiting holds.','Dear [% borrower.firstname %] [% borrower.surname %],\r\n\r\nThe follwing holds are waiting at [% branch.branchname %]:\r\n\\r\n[% FOREACH hold IN holds %]\r\n [% hold.biblio.title %] : waiting since [% hold.waitingdate %]\r\n[% END %]','email'), Git bisect showed that the error is since ea6467724cf8e6fac2224e1dcb6c6ddee73736af Bug 15986: Add sample notice to translated notices Which added the line on row 15 Test plan (with koha testing docker): 1. in .env file set KOHA_MARC_FLAVOUR=unimarc 2. start the instance 3. fail! Full error messages: https://privatebin.deblan.org/?7e440eb0ce80f1f4#6sRbG9qywKQjCNDDHiDSWcrFneDCJBs96GuxqqKvzHu8 Not sure about criticality. Maybe it should be higher that "normal" since it hinders testing unimarc stuff