Bug 28206

Summary: Waiting holds should be filled at checkout even if they violate holds policies
Product: Koha Reporter: Andrew Fuerste-Henry <andrew>
Component: CirculationAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: gmcharlt, jonathan.druart, kebliss, kyle.m.hall
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10452
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11919
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 28206: Move tests to a subtest
Bug 28206: Add tests

Description Andrew Fuerste-Henry 2021-04-23 14:52:14 UTC
To recreate:
- have or create a valid hold
- check the item in, capture the hold
- confirm the hold shows as waiting for the patron
- set AllowHoldsOnDamagedItems to Don't Allow
- mark the item as damamged
- try to place another hold on this same bib for another patron of the same category, confirm that hold is no longer valid because the item is no longer considered valid
- check the item out to your original patron
- confirm the hold still shows as Waiting and no feedback is given as to why

I'd like Koha to simply mark that hold as filled -- if the library is doing the checkout, they likely want the hold filled. Alternatively, we should at least give an alert that mentions the hold and asks whether it should be filled, cancelled, or reverted.
Comment 1 Jonathan Druart 2021-04-30 09:30:16 UTC
Andrew, does it mean bug 10452 was incorrect?
Comment 2 Jonathan Druart 2021-04-30 09:46:36 UTC
Created attachment 120331 [details] [review]
Bug 28206: Move tests to a subtest
Comment 3 Jonathan Druart 2021-04-30 09:46:40 UTC
Created attachment 120332 [details] [review]
Bug 28206: Add tests