Summary: | Fix vendor list group by in serials statistics wizard | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | Serials | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | andrew, david, nugged, romain.hinet-debain, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This fixes an issue where vendors are repeated in the serials report.
|
Version(s) released in: |
22.05.00,21.05.08
|
Circulation function: | |||
Bug Depends on: | 24940 | ||
Bug Blocks: | |||
Attachments: |
Bug 28216: Fix vendor list group by in serials statistics wizard
Bug 28216: Fix vendor list group by in serials statistics wizard Bug 28216: Fix vendor list group by in serials statistics wizard Bug 28216: Fix vendor list group by in serials statistics wizard Bug 28216: Fix vendor list group by in serials statistics wizard |
Description
Fridolin Somers
2021-04-26 07:33:37 UTC
Created attachment 120163 [details] [review] Bug 28216: Fix vendor list group by in serials statistics wizard Bug 24940 added sort vendor list by aqbookseller.name but removed accidentally the group by. Now vendors are repeated in the list. Test plan : 1) Create several subscriptions for same vendor 2) Go to Reports > Serials 3) Check list of vendors => Without patch you see the same vendor several times => With patch you seen it once 4) Check sort is still on vendor name I get an error: Plack::App::WrapCGI::call(): DBI Exception: DBD::mysql::st execute failed: 'koha_kohadev.subscription.aqbooksellerid' isn't in GROUP BY [for Statement "SELECT aqbooksellerid, aqbooksellers.name FROM subscription LEFT JOIN aqbooksellers ON (subscription.aqbooksellerid=aqbooksellers.id ) GROUP BY aqbooksellers.id ORDER BY aqbooksellers.name ASC "] at /usr/share/perl5/Plack/Component.pm line 50 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 Oh I see Created attachment 120755 [details] [review] Bug 28216: Fix vendor list group by in serials statistics wizard Bug 24940 added sort vendor list by aqbookseller.name but removed accidentally the group by. Now vendors are repeated in the list. Test plan : 1) Create several subscriptions for same vendor 2) Go to Reports > Serials 3) Check list of vendors => Without patch you see the same vendor several times => With patch you seen it once 4) Check sort is still on vendor name I have a message "Error trace" when i click to "Serials statistics wizard" https://staff-amu.sandboxes.biblibre.eu/cgi-bin/koha/reports/serials_stats.pl Hi, Without the patch I have the same message error trace, when clic to "serial statistics wizards https://staff-amu.sandboxes.biblibre.eu/cgi-bin/koha/reports/serials_stats.pl Ah another mistake : DBD::mysql::st execute failed: 'aqbooksellers.name' isn't in GROUP BY Created attachment 125446 [details] [review] Bug 28216: Fix vendor list group by in serials statistics wizard Bug 24940 added sort vendor list by aqbookseller.name but removed accidentally the group by. Now vendors are repeated in the list. Test plan : 1) Create several subscriptions for same vendor 2) Go to Reports > Serials 3) Check list of vendors => Without patch you see the same vendor several times => With patch you seen it once 4) Check sort is still on vendor name Created attachment 128424 [details] [review] Bug 28216: Fix vendor list group by in serials statistics wizard Bug 24940 added sort vendor list by aqbookseller.name but removed accidentally the group by. Now vendors are repeated in the list. Test plan : 1) Create several subscriptions for same vendor 2) Go to Reports > Serials 3) Check list of vendors => Without patch you see the same vendor several times => With patch you seen it once 4) Check sort is still on vendor name Signed-off-by: Samu Heiskanen <samu.heiskanen@hypernova.fi> Created attachment 128462 [details] [review] Bug 28216: Fix vendor list group by in serials statistics wizard Bug 24940 added sort vendor list by aqbookseller.name but removed accidentally the group by. Now vendors are repeated in the list. Test plan : 1) Create several subscriptions for same vendor 2) Go to Reports > Serials 3) Check list of vendors => Without patch you see the same vendor several times => With patch you seen it once 4) Check sort is still on vendor name Signed-off-by: Samu Heiskanen <samu.heiskanen@hypernova.fi> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 22.05, thanks to everybody involved [U+1F984] Pushed to 21.05.x for 21.05.08 (looks like this is in 21.11 but not noted here yet) Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. |