| Summary: | Follow up to bug 23463 - use item_object in misc/cronjobs/delete_items.pl | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Command-line Utilities | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | andrew, fridolin.somers, george, robin, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29794 | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.05.00,20.11.06,20.05.12
|
|
| Circulation function: | |||
| Bug Depends on: | 23463 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 28255: Follow up to bug 23463 - use item_object in misc/cronjobs/delete_items.pl
Bug 28255: Follow up to bug 23463 - use item_object in misc/cronjobs/delete_items.pl Bug 28255: Follow up to bug 23463 - use item_object in misc/cronjobs/delete_items.pl |
||
|
Description
Nick Clemens (kidclamp)
2021-04-28 17:57:39 UTC
Created attachment 120280 [details] [review] Bug 28255: Follow up to bug 23463 - use item_object in misc/cronjobs/delete_items.pl This looks like just an assumption that the $item variable was an object Correct the code to use $item_object To test: 1 - perl misc/cronjobs/delete_items.pl -where="barcode LIKE '%8'" --commit --verbose 2 - Can't call method "safe_delete" on unblessed reference at /usr/share/koha/bin/cronjobs/delete_items.pl line 67. 3 - Apply patch 4 - Repeat 5 - Success! You deleted a bunch of items Created attachment 120904 [details] [review] Bug 28255: Follow up to bug 23463 - use item_object in misc/cronjobs/delete_items.pl This looks like just an assumption that the $item variable was an object Correct the code to use $item_object To test: 1 - perl misc/cronjobs/delete_items.pl -where="barcode LIKE '%8'" --commit --verbose 2 - Can't call method "safe_delete" on unblessed reference at /usr/share/koha/bin/cronjobs/delete_items.pl line 67. 3 - Apply patch 4 - Repeat 5 - Success! You deleted a bunch of items Signed-off-by: David Nind <david@davidnind.com> Created attachment 121107 [details] [review] Bug 28255: Follow up to bug 23463 - use item_object in misc/cronjobs/delete_items.pl This looks like just an assumption that the $item variable was an object Correct the code to use $item_object To test: 1 - perl misc/cronjobs/delete_items.pl -where="barcode LIKE '%8'" --commit --verbose 2 - Can't call method "safe_delete" on unblessed reference at /usr/share/koha/bin/cronjobs/delete_items.pl line 67. 3 - Apply patch 4 - Repeat 5 - Success! You deleted a bunch of items Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.06 Pushed to 20.05.x for 20.05.12 Missing dependencies for 19.11.x, no backport. |