Summary: | Add visual feedback on overridden pickup locations on patron's page | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | Hold requests | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | gmcharlt, jonathan.druart, kyle, martin.renvoize, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.11.00
|
|
Circulation function: | |||
Bug Depends on: | 27864, 27865 | ||
Bug Blocks: | |||
Attachments: |
Bug 28261: Add visual feedback on overridden pickup locations on patron's page
Bug 28261: Add visual feedback on overridden pickup locations on patron's page Too long library name makes the icon drop down Bug 28261: Add visual feedback on overridden pickup locations on patron's page Bug 28261: (QA follow-up) Fix width after adding visual feedback |
Description
Tomás Cohen Arazi (tcohen)
2021-04-29 11:09:06 UTC
Created attachment 120313 [details] [review] Bug 28261: Add visual feedback on overridden pickup locations on patron's page This patch makes the patron pages in the staff interface use the API and Select2 to render the pickup locations list. This has the effect of adding visual feedback on those pickup locations that need an override, based on the current configuration options. All the checks are done in the GET /holds/:hold_id/pickup_locations route, so this is a fairly trivial change. To test: 1. Have a couple holds for a patron, some overrriden, some not 2. Visit the patrons' detail page, holds tab. => SUCCESS: You see the holds, pickup location has a dropdown 3. Repeat in the circulation tab for the patron => SUCCESS: You see the holds, pickup location has a dropdown 4. Apply this patch 5. Repeat 2 and 3 => SUCCESS: Same behavior as before, but the dropdown is rendered with Select2 and has a search feature. Overridden pickup locations have an icon telling so 6. Sign off :-D Created attachment 120493 [details] [review] Bug 28261: Add visual feedback on overridden pickup locations on patron's page This patch makes the patron pages in the staff interface use the API and Select2 to render the pickup locations list. This has the effect of adding visual feedback on those pickup locations that need an override, based on the current configuration options. All the checks are done in the GET /holds/:hold_id/pickup_locations route, so this is a fairly trivial change. To test: 1. Have a couple holds for a patron, some overrriden, some not 2. Visit the patrons' detail page, holds tab. => SUCCESS: You see the holds, pickup location has a dropdown 3. Repeat in the circulation tab for the patron => SUCCESS: You see the holds, pickup location has a dropdown 4. Apply this patch 5. Repeat 2 and 3 => SUCCESS: Same behavior as before, but the dropdown is rendered with Select2 and has a search feature. Overridden pickup locations have an icon telling so 6. Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Works well, signing off Slight display problem with long library names Created attachment 123111 [details]
Too long library name makes the icon drop down
Display issue when library name is long
(In reply to Nick Clemens from comment #5) > Created attachment 123111 [details] > Too long library name makes the icon drop down > > Display issue when library name is long I haven't tried but maybe it's not caused by this patch. I opened bug 26288 some times ago, that seems related. Created attachment 123252 [details] [review] Bug 28261: Add visual feedback on overridden pickup locations on patron's page This patch makes the patron pages in the staff interface use the API and Select2 to render the pickup locations list. This has the effect of adding visual feedback on those pickup locations that need an override, based on the current configuration options. All the checks are done in the GET /holds/:hold_id/pickup_locations route, so this is a fairly trivial change. To test: 1. Have a couple holds for a patron, some overrriden, some not 2. Visit the patrons' detail page, holds tab. => SUCCESS: You see the holds, pickup location has a dropdown 3. Repeat in the circulation tab for the patron => SUCCESS: You see the holds, pickup location has a dropdown 4. Apply this patch 5. Repeat 2 and 3 => SUCCESS: Same behavior as before, but the dropdown is rendered with Select2 and has a search feature. Overridden pickup locations have an icon telling so 6. Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 123253 [details] [review] Bug 28261: (QA follow-up) Fix width after adding visual feedback Signed-off-by: Nick Clemens <nick@bywatersolutions.com> (not related to this patch but we have .hold_location_select and .pickup_location_dropdown) Pushed to master for 21.11, thanks to everybody involved! |